[PATCH] tty: clearify structure initializer in notify_write()

[PATCH] tty: clearify structure initializer in notify_write()

[Mathias Krause]

Even though this is valid C we should not mix C99 initializers with
obfuscated ANSI C. Stick to C99 and initialize c by its name.

Found by clang:
drivers/tty/vt/vt.c:262:55: warning: explicitly assigning a variable of
type 'unsigned int' to itself [-Wself-assign]
    struct vt_notifier_param param = { .vc = vc, unicode = unicode };
                                                 ~~~~~~~ ^ ~~~~~~~

Signed-off-by: Mathias Krause <minipli@googlemail.com>
---
 drivers/tty/vt/vt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index b3915b7..e716839 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -259,7 +259,7 @@ EXPORT_SYMBOL_GPL(unregister_vt_notifier);
 
 static void notify_write(struct vc_data *vc, unsigned int unicode)
 {
-	struct vt_notifier_param param = { .vc = vc, unicode = unicode };
+	struct vt_notifier_param param = { .vc = vc, .c = unicode };
 	atomic_notifier_call_chain(&vt_notifier_list, VT_WRITE, &param);
 }
 
-- 
1.5.6.5

Re: [PATCH] tty: clearify structure initializer in notify_write()

[Mathias Krause]

Ping, Greg?

On Sat, Jul 30, 2011 at 2:01 PM, Mathias Krause <minipli@googlemail.com> wrote:
> Even though this is valid C we should not mix C99 initializers with
> obfuscated ANSI C. Stick to C99 and initialize c by its name.
>
> Found by clang:
> drivers/tty/vt/vt.c:262:55: warning: explicitly assigning a variable of
> type 'unsigned int' to itself [-Wself-assign]
>    struct vt_notifier_param param = { .vc = vc, unicode = unicode };
>                                                 ~~~~~~~ ^ ~~~~~~~
>
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
> ---
>  drivers/tty/vt/vt.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index b3915b7..e716839 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -259,7 +259,7 @@ EXPORT_SYMBOL_GPL(unregister_vt_notifier);
>
>  static void notify_write(struct vc_data *vc, unsigned int unicode)
>  {
> -       struct vt_notifier_param param = { .vc = vc, unicode = unicode };
> +       struct vt_notifier_param param = { .vc = vc, .c = unicode };
>        atomic_notifier_call_chain(&vt_notifier_list, VT_WRITE, &param);
>  }
>
> --
> 1.5.6.5

Re: [PATCH] tty: clearify structure initializer in notify_write()

[Dan Carpenter]

> On Sat, Jul 30, 2011 at 2:01 PM, Mathias Krause <minipli@googlemail.com> wrote:
> > Even though this is valid C we should not mix C99 initializers with
> > obfuscated ANSI C.

I saw this patch the first time and I couldn't figure out why the
original code was written that way.  I'm curious, is there some trick
here that I don't see, or is it just a typo that happens to work?

regards,
dan carpenter

Re: [PATCH] tty: clearify structure initializer in notify_write()

[Alan Cox]

On Tue, 16 Aug 2011 18:04:52 +0300
Dan Carpenter <error27@gmail.com> wrote:

> > On Sat, Jul 30, 2011 at 2:01 PM, Mathias Krause <minipli@googlemail.com> wrote:
> > > Even though this is valid C we should not mix C99 initializers with
> > > obfuscated ANSI C.
> 
> I saw this patch the first time and I couldn't figure out why the
> original code was written that way.  I'm curious, is there some trick
> here that I don't see, or is it just a typo that happens to work?

Typo looking at the original commit