From: Felipe Balbi <balbi@ti.com>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Felipe Balbi <balbi@ti.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Yang Rui Rui <ruirui.r.yang@tieto.com>,
Dave Young <hidave.darkstar@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 1/4] usb: Provide usb_speed_string() function
Date: Wed, 24 Aug 2011 11:57:39 +0300 [thread overview]
Message-ID: <20110824085738.GE12549@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <op.v0mv05vu3l0zgt@mnazarewicz-glaptop>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
Hi,
On Mon, Aug 22, 2011 at 11:16:07PM +0200, Michal Nazarewicz wrote:
> >>>>+obj-$(CONFIG_USB) += common.o
> >>>>+obj-$(CONFIG_USB_GADGET) += common.o
>
> >>>Will this cause problems? For example, what if CONFIG_USB is Y and
> >>>CONFIG_USB_GADGET is M?
>
> >>>Also, it seems a little silly to have an entire kernel module devoted
> >>>to a single, little function.
>
> On Mon, 22 Aug 2011 23:06:43 +0200, Alan Stern
> <stern@rowland.harvard.edu> wrote:
> >You could do:
> >
> > obj-$(CONFIG_USB_SUPPORT) += common.o
> >
> >which would build that subroutine into the main kernel whenever either
> >side of the USB stack is enabled.
>
> OK. I'll wait for any more possible comments and post changed version
> by the end of the week.
if it's only for one single function, wouldn't a static inline in a
common header do ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-08-24 8:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 16:04 [PATCHv4 0/4] Removing USB_GADGET_*SPEED macros Michal Nazarewicz
2011-08-22 16:04 ` [PATCHv4 1/4] usb: Provide usb_speed_string() function Michal Nazarewicz
2011-08-22 17:28 ` Alan Stern
2011-08-22 19:42 ` Michal Nazarewicz
2011-08-22 21:06 ` Alan Stern
2011-08-22 21:16 ` Michal Nazarewicz
2011-08-24 8:57 ` Felipe Balbi [this message]
2011-08-24 12:59 ` Michal Nazarewicz
2011-08-24 2:16 ` Dave Young
2011-08-22 16:04 ` [PATCHv4 2/4] usb: gadget: replace "is_dualspeed" with "max_speed" Michal Nazarewicz
2011-08-22 16:04 ` [PATCHv4 3/4] usb: gadget: rename usb_gadget_driver::speed to max_speed Michal Nazarewicz
2011-08-24 2:26 ` Dave Young
2011-08-24 8:58 ` Felipe Balbi
2011-08-24 13:26 ` Michal Nazarewicz
2011-08-22 16:04 ` [PATCHv4 4/4] usb: gadget: get rid of USB_GADGET_{DUAL,SUPER}SPEED Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110824085738.GE12549@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=hidave.darkstar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=ruirui.r.yang@tieto.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®