[PATCH] Input: adp5588-keys - remove incorrect modalias

[PATCH] Input: adp5588-keys - remove incorrect modalias

[Axel Lin]

>From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001
From: Axel Lin <axel.lin@gmail.com>
Date: Thu, 25 Aug 2011 18:26:56 +0800
Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias

For i2c drivers, we should use "i2c:" prefix for modalias.
MODULE_DEVICE_TABLE will setup the modulalias for us,
thus adding a MODULE_ALIAS here seems redundant.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/input/keyboard/adp5588-keys.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
index 7b404e54..e34eeb8 100644
--- a/drivers/input/keyboard/adp5588-keys.c
+++ b/drivers/input/keyboard/adp5588-keys.c
@@ -668,4 +668,3 @@ module_exit(adp5588_exit);
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");
 MODULE_DESCRIPTION("ADP5588/87 Keypad driver");
-MODULE_ALIAS("platform:adp5588-keys");
-- 
1.7.4.1

RE: [PATCH] Input: adp5588-keys - remove incorrect modalias

[Hennerich, Michael]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1506 bytes --]

Axel Lin wrote on 2011-08-25:
> From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001
> From: Axel Lin <axel.lin@gmail.com>
> Date: Thu, 25 Aug 2011 18:26:56 +0800
> Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias
>
> For i2c drivers, we should use "i2c:" prefix for modalias.
> MODULE_DEVICE_TABLE will setup the modulalias for us,
> thus adding a MODULE_ALIAS here seems redundant.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
>  drivers/input/keyboard/adp5588-keys.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> diff --git a/drivers/input/keyboard/adp5588-keys.c
> b/drivers/input/keyboard/adp5588-keys.c index 7b404e54..e34eeb8 100644
> --- a/drivers/input/keyboard/adp5588-keys.c +++
> b/drivers/input/keyboard/adp5588-keys.c @@ -668,4 +668,3 @@
> module_exit(adp5588_exit);
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");
>  MODULE_DESCRIPTION("ADP5588/87 Keypad driver");
> -MODULE_ALIAS("platform:adp5588-keys");

Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif


ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] Input: adp5588-keys - remove incorrect modalias

[Dmitry Torokhov]

On Thu, Aug 25, 2011 at 11:43:53AM +0100, Hennerich, Michael wrote:
> Axel Lin wrote on 2011-08-25:
> > From 2b642fd34e59291764f5149f083d84760d8b41b2 Mon Sep 17 00:00:00 2001
> > From: Axel Lin <axel.lin@gmail.com>
> > Date: Thu, 25 Aug 2011 18:26:56 +0800
> > Subject: [PATCH] Input: adp5588-keys - remove incorrect modalias
> >
> > For i2c drivers, we should use "i2c:" prefix for modalias.
> > MODULE_DEVICE_TABLE will setup the modulalias for us,
> > thus adding a MODULE_ALIAS here seems redundant.
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> 
> Acked-by: Michael Hennerich <michael.hennerich@analog.com>

Applied, thanks Axel.

-- 
Dmitry