From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, <gregkh@suse.de>,
<akpm@linux-foundation.org>, <art@ified.ca>, <arnd@arndb.de>,
<jslaby@suse.cz>
Subject: Re: [PATCH] vt_ioctl.c: fix compile error with pm_set_vt_switch()
Date: Sat, 3 Sep 2011 11:46:41 +0100 [thread overview]
Message-ID: <20110903114641.53170fef@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <201109021402.42503.hartleys@visionengravers.com>
On Fri, 2 Sep 2011 14:02:42 -0700
H Hartley Sweeten <hartleys@visionengravers.com> wrote:
> When CONFIG_PM_SLEEP, CONFIG_VT, and CONFIG_VT_CONSOLE are not enabled
> the function pm_set_vt_switch() is defined as an inline in linux/suspend.h. This causes
> a compile error if CONFIG_VT is enabled.
>
> drivers/tty/vt/vt_ioctl.c:1794: error: redefinition of 'pm_set_vt_switch'
> include/linux/suspend.h:17: error: previous definition of 'pm_set_vt_switch' was here
>
> Fix this with an #if defined guard around the function in vt_ioctl.c.
Can you put the #if uglies into the buggy suspend.h header instead so the
code proper is kept clean of ifdefs.
Alan
next prev parent reply other threads:[~2011-09-03 10:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 21:02 H Hartley Sweeten
2011-09-03 10:46 ` Alan Cox [this message]
2011-09-05 14:54 ` Arnd Bergmann
2011-09-06 18:26 ` H Hartley Sweeten
2011-09-06 19:29 ` Arnd Bergmann
2011-09-06 20:23 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110903114641.53170fef@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=art@ified.ca \
--cc=gregkh@suse.de \
--cc=hartleys@visionengravers.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®