From: Arnd Bergmann <arnd@arndb.de>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"gregkh@suse.de" <gregkh@suse.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"art@ified.ca" <art@ified.ca>, "jslaby@suse.cz" <jslaby@suse.cz>
Subject: Re: [PATCH] vt_ioctl.c: fix compile error with pm_set_vt_switch()
Date: Tue, 06 Sep 2011 21:29:18 +0200 [thread overview]
Message-ID: <6392794.F5gNpf4v9p@wuerfel> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F001F39D748B6E@AUSP01VMBX24.collaborationhost.net>
On Tuesday 06 September 2011 13:26:12 H Hartley Sweeten wrote:
> Your patch below does appear to fix the problem.
>
> Tested-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
>
> There is still a bit of #if ugliness with the pm_{prepare,restore}_console.
>
> The source file kernel/power/console.c is compiled when CONFIG_PM_SLEEP is
> enabled. But that file ends up empty if CONFIG_VT and CONFIG_VT_CONSOLE are
> not defined.
>
> I wonder if it would be cleaner to make a new entry in kernel/power/Kconfig:
>
> config PM_SLEEP_CONSOLE
> def_bool y
> depends on PM_SLEEP && VT && VT_CONSOLE
>
> Then use that config option in the Makefile and in suspend.h.
Yes, that would be cleaner. I would probably move it to drivers/tty/vt
in the same step and name the option VT_CONSOLE_SLEEP.
Do you want to send a patch?
Thanks for testing!
Arnd
next prev parent reply other threads:[~2011-09-06 19:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 21:02 H Hartley Sweeten
2011-09-03 10:46 ` Alan Cox
2011-09-05 14:54 ` Arnd Bergmann
2011-09-06 18:26 ` H Hartley Sweeten
2011-09-06 19:29 ` Arnd Bergmann [this message]
2011-09-06 20:23 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6392794.F5gNpf4v9p@wuerfel \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=art@ified.ca \
--cc=gregkh@suse.de \
--cc=hartleys@visionengravers.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®