From: Greg KH <greg@kroah.com>
To: Johannes Thumshirn <morbidrsa@googlemail.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: Removed unnecessary "extern" from do_become_nonbusy()
Date: Tue, 6 Sep 2011 16:58:46 -0700 [thread overview]
Message-ID: <20110906235846.GA10622@kroah.com> (raw)
In-Reply-To: <1315150589-3434-1-git-send-email-morbidrsa@googlemail.com>
On Sun, Sep 04, 2011 at 05:36:29PM +0200, Johannes Thumshirn wrote:
> Removed unnecessary "extern" label from do_become_nonbusy() function to make
> checkpatch.pl happy
>
> Signed-off-by: Johannes Thumshirn <morbidrsa@googlemail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index e90e3cc..c46db8f 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -101,8 +101,7 @@ static int do_insn_ioctl(struct comedi_device *dev,
> static int do_poll_ioctl(struct comedi_device *dev, unsigned int subd,
> void *file);
>
> -extern void do_become_nonbusy(struct comedi_device *dev,
> - struct comedi_subdevice *s);
> +void do_become_nonbusy(struct comedi_device *dev, struct comedi_subdevice *s);
This patch does not apply, what tree did you make it against?
Please try it against the latest linux-next tree and resend it.
thanks,
greg k-h
prev parent reply other threads:[~2011-09-07 0:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-04 15:36 Johannes Thumshirn
2011-09-06 23:58 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110906235846.GA10622@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=morbidrsa@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®