* [PATCH] Staging: comedi: Removed unnecessary "extern" from do_become_nonbusy()
@ 2011-09-04 15:36 Johannes Thumshirn
2011-09-06 23:58 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Thumshirn @ 2011-09-04 15:36 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Johannes Thumshirn
Removed unnecessary "extern" label from do_become_nonbusy() function to make
checkpatch.pl happy
Signed-off-by: Johannes Thumshirn <morbidrsa@googlemail.com>
---
drivers/staging/comedi/comedi_fops.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index e90e3cc..c46db8f 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -101,8 +101,7 @@ static int do_insn_ioctl(struct comedi_device *dev,
static int do_poll_ioctl(struct comedi_device *dev, unsigned int subd,
void *file);
-extern void do_become_nonbusy(struct comedi_device *dev,
- struct comedi_subdevice *s);
+void do_become_nonbusy(struct comedi_device *dev, struct comedi_subdevice *s);
static int do_cancel(struct comedi_device *dev, struct comedi_subdevice *s);
static int comedi_fasync(int fd, struct file *file, int on);
--
1.7.4.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: comedi: Removed unnecessary "extern" from do_become_nonbusy()
2011-09-04 15:36 [PATCH] Staging: comedi: Removed unnecessary "extern" from do_become_nonbusy() Johannes Thumshirn
@ 2011-09-06 23:58 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2011-09-06 23:58 UTC (permalink / raw)
To: Johannes Thumshirn; +Cc: gregkh, devel, linux-kernel
On Sun, Sep 04, 2011 at 05:36:29PM +0200, Johannes Thumshirn wrote:
> Removed unnecessary "extern" label from do_become_nonbusy() function to make
> checkpatch.pl happy
>
> Signed-off-by: Johannes Thumshirn <morbidrsa@googlemail.com>
> ---
> drivers/staging/comedi/comedi_fops.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index e90e3cc..c46db8f 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -101,8 +101,7 @@ static int do_insn_ioctl(struct comedi_device *dev,
> static int do_poll_ioctl(struct comedi_device *dev, unsigned int subd,
> void *file);
>
> -extern void do_become_nonbusy(struct comedi_device *dev,
> - struct comedi_subdevice *s);
> +void do_become_nonbusy(struct comedi_device *dev, struct comedi_subdevice *s);
This patch does not apply, what tree did you make it against?
Please try it against the latest linux-next tree and resend it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-07 0:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-04 15:36 [PATCH] Staging: comedi: Removed unnecessary "extern" from do_become_nonbusy() Johannes Thumshirn
2011-09-06 23:58 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®