From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Colin Cross <ccross@android.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH 1/3] fs: seq_file: add seq_reserve
Date: Thu, 22 Sep 2011 23:54:17 +0100 [thread overview]
Message-ID: <20110922235417.6cf88f7d@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1316725029-22737-2-git-send-email-ccross@android.com>
On Thu, 22 Sep 2011 13:57:07 -0700
Colin Cross <ccross@android.com> wrote:
> Adds a seq_reserve function to allow users of the seq_file interface to
> increase the initial size of the buffer. Avoids repeated allocations and
> calls to the show function in cases where large buffers of known size are
> needed.
Would it not be better to have something akin to
void seq_set_buffer(struct seq_file *m, void *ptr, size_t size)
{
m->buf = ptr;
m->size = size;
m->private = 1;
}
and let the caller simply provide a buffer by any means it wishes (even
statically) and free it again itself. That keeps the caller fully in
control when it wishes to be.
Alan
next prev parent reply other threads:[~2011-09-22 22:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 20:57 [PATCH 0/3] Replace kmalloc with vmalloc in seq_files Colin Cross
2011-09-22 20:57 ` [PATCH 1/3] fs: seq_file: add seq_reserve Colin Cross
2011-09-22 22:54 ` Alan Cox [this message]
2011-09-22 23:24 ` Colin Cross
2011-09-22 20:57 ` [PATCH 2/3] sched_stats: use the new seq_reserve function Colin Cross
2011-09-22 20:57 ` [PATCH 3/3] seq_file: convert seq buffer to vmalloc Colin Cross
2011-09-22 21:07 ` Joe Perches
2011-09-22 21:19 ` Colin Cross
2011-09-22 23:26 ` NamJae Jeon
2011-09-22 21:20 ` Peter Zijlstra
2011-09-22 21:22 ` [PATCH 0/3] Replace kmalloc with vmalloc in seq_files Peter Zijlstra
2011-09-22 21:23 ` Christoph Hellwig
2011-09-23 0:00 ` Colin Cross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110922235417.6cf88f7d@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ccross@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®