* [patch] dma/timberdale: free_irq() on an error path
@ 2011-09-23 6:16 Dan Carpenter
2011-10-07 4:58 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-09-23 6:16 UTC (permalink / raw)
To: Vinod Koul; +Cc: Dan Williams, linux-kernel, kernel-janitors
There was an error path that skipped the free_irq() step by mistake.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c
index 6dbdf45..a4a398f 100644
--- a/drivers/dma/timb_dma.c
+++ b/drivers/dma/timb_dma.c
@@ -762,7 +762,7 @@ static int __devinit td_probe(struct platform_device *pdev)
if ((i % 2) == pchan->rx) {
dev_err(&pdev->dev, "Wrong channel configuration\n");
err = -EINVAL;
- goto err_tasklet_kill;
+ goto err_free_irq;
}
td_chan->chan.device = &td->dma;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch] dma/timberdale: free_irq() on an error path
2011-09-23 6:16 [patch] dma/timberdale: free_irq() on an error path Dan Carpenter
@ 2011-10-07 4:58 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2011-10-07 4:58 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Dan Williams, linux-kernel, kernel-janitors
On Fri, 2011-09-23 at 09:16 +0300, Dan Carpenter wrote:
> There was an error path that skipped the free_irq() step by mistake.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c
> index 6dbdf45..a4a398f 100644
> --- a/drivers/dma/timb_dma.c
> +++ b/drivers/dma/timb_dma.c
> @@ -762,7 +762,7 @@ static int __devinit td_probe(struct platform_device *pdev)
> if ((i % 2) == pchan->rx) {
> dev_err(&pdev->dev, "Wrong channel configuration\n");
> err = -EINVAL;
> - goto err_tasklet_kill;
> + goto err_free_irq;
> }
>
> td_chan->chan.device = &td->dma;
Applied thanks
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-07 5:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-23 6:16 [patch] dma/timberdale: free_irq() on an error path Dan Carpenter
2011-10-07 4:58 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®