* [PATCH] ceph/super.c: quiet sparse noise
@ 2011-09-23 18:53 H Hartley Sweeten
2011-09-23 19:06 ` Sage Weil
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2011-09-23 18:53 UTC (permalink / raw)
To: Linux Kernel; +Cc: ceph-devel, sage
Quiet the sparse noise:
warning: symbol 'create_fs_client' was not declared. Should it be static?
warning: symbol 'destroy_fs_client' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Sage Weil <sage@newdream.net>
ceph-devel@vger.kernel.org
---
diff --git a/fs/ceph/super.c b/fs/ceph/super.c
index e0a6a06..bbc1b78 100644
--- a/fs/ceph/super.c
+++ b/fs/ceph/super.c
@@ -426,7 +426,7 @@ static int extra_mon_dispatch(struct ceph_client *client, struct ceph_msg *msg)
/*
* create a new fs client
*/
-struct ceph_fs_client *create_fs_client(struct ceph_mount_options *fsopt,
+static struct ceph_fs_client *create_fs_client(struct ceph_mount_options *fsopt,
struct ceph_options *opt)
{
struct ceph_fs_client *fsc;
@@ -502,7 +502,7 @@ fail:
return ERR_PTR(err);
}
-void destroy_fs_client(struct ceph_fs_client *fsc)
+static void destroy_fs_client(struct ceph_fs_client *fsc)
{
dout("destroy_fs_client %p\n", fsc);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ceph/super.c: quiet sparse noise
2011-09-23 18:53 [PATCH] ceph/super.c: quiet sparse noise H Hartley Sweeten
@ 2011-09-23 19:06 ` Sage Weil
0 siblings, 0 replies; 2+ messages in thread
From: Sage Weil @ 2011-09-23 19:06 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, ceph-devel
Applied, thanks!
sage
On Fri, 23 Sep 2011, H Hartley Sweeten wrote:
> Quiet the sparse noise:
>
> warning: symbol 'create_fs_client' was not declared. Should it be static?
> warning: symbol 'destroy_fs_client' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Sage Weil <sage@newdream.net>
> ceph-devel@vger.kernel.org
>
> ---
>
> diff --git a/fs/ceph/super.c b/fs/ceph/super.c
> index e0a6a06..bbc1b78 100644
> --- a/fs/ceph/super.c
> +++ b/fs/ceph/super.c
> @@ -426,7 +426,7 @@ static int extra_mon_dispatch(struct ceph_client *client, struct ceph_msg *msg)
> /*
> * create a new fs client
> */
> -struct ceph_fs_client *create_fs_client(struct ceph_mount_options *fsopt,
> +static struct ceph_fs_client *create_fs_client(struct ceph_mount_options *fsopt,
> struct ceph_options *opt)
> {
> struct ceph_fs_client *fsc;
> @@ -502,7 +502,7 @@ fail:
> return ERR_PTR(err);
> }
>
> -void destroy_fs_client(struct ceph_fs_client *fsc)
> +static void destroy_fs_client(struct ceph_fs_client *fsc)
> {
> dout("destroy_fs_client %p\n", fsc);
>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-23 19:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-23 18:53 [PATCH] ceph/super.c: quiet sparse noise H Hartley Sweeten
2011-09-23 19:06 ` Sage Weil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®