* [PATCH] ext2/xattr_security.c: local functions should be static
@ 2011-09-23 20:51 H Hartley Sweeten
2011-10-04 23:37 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2011-09-23 20:51 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-ext4, jack
This quiets the sparse noise:
warning: symbol 'ext2_initxattrs' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Jan Kara <jack@suse.cz>
---
diff --git a/fs/ext2/xattr_security.c b/fs/ext2/xattr_security.c
index c922adc..ed1a5d5 100644
--- a/fs/ext2/xattr_security.c
+++ b/fs/ext2/xattr_security.c
@@ -46,7 +46,7 @@ ext2_xattr_security_set(struct dentry *dentry, const char *name,
value, size, flags);
}
-int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+static int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
void *fs_info)
{
const struct xattr *xattr;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ext2/xattr_security.c: local functions should be static
2011-09-23 20:51 [PATCH] ext2/xattr_security.c: local functions should be static H Hartley Sweeten
@ 2011-10-04 23:37 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2011-10-04 23:37 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, linux-ext4, jack
On Fri 23-09-11 13:51:24, H Hartley Sweeten wrote:
> This quiets the sparse noise:
>
> warning: symbol 'ext2_initxattrs' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Jan Kara <jack@suse.cz>
Hmm, this patch doesn't seem to be against latest Linus kernel... At
least I don't see ext2_initxattrs() there - although I remember seeing
patches adding this function flying somewhere.
Honza
> diff --git a/fs/ext2/xattr_security.c b/fs/ext2/xattr_security.c
> index c922adc..ed1a5d5 100644
> --- a/fs/ext2/xattr_security.c
> +++ b/fs/ext2/xattr_security.c
> @@ -46,7 +46,7 @@ ext2_xattr_security_set(struct dentry *dentry, const char *name,
> value, size, flags);
> }
>
> -int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +static int ext2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> void *fs_info)
> {
> const struct xattr *xattr;
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-04 23:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-23 20:51 [PATCH] ext2/xattr_security.c: local functions should be static H Hartley Sweeten
2011-10-04 23:37 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®