* [PATCH] ext3/balloc.c: local functions should be static
@ 2011-09-23 20:55 H Hartley Sweeten
2011-10-04 23:29 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2011-09-23 20:55 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-ext4, jack, akpm, adilger.kernel
This quites the sparse noise:
warning: symbol 'ext3_trim_all_free' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
---
diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c
index 6386d76..8e62ec5 100644
--- a/fs/ext3/balloc.c
+++ b/fs/ext3/balloc.c
@@ -1924,9 +1924,10 @@ unsigned long ext3_bg_num_gdb(struct super_block *sb, int group)
* reaches any used block. Then issue a TRIM command on this extent and free
* the extent in the block bitmap. This is done until whole group is scanned.
*/
-ext3_grpblk_t ext3_trim_all_free(struct super_block *sb, unsigned int group,
- ext3_grpblk_t start, ext3_grpblk_t max,
- ext3_grpblk_t minblocks)
+static ext3_grpblk_t ext3_trim_all_free(struct super_block *sb,
+ unsigned int group,
+ ext3_grpblk_t start, ext3_grpblk_t max,
+ ext3_grpblk_t minblocks)
{
handle_t *handle;
ext3_grpblk_t next, free_blocks, bit, freed, count = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ext3/balloc.c: local functions should be static
2011-09-23 20:55 [PATCH] ext3/balloc.c: local functions should be static H Hartley Sweeten
@ 2011-10-04 23:29 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2011-10-04 23:29 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, linux-ext4, jack, akpm, adilger.kernel
On Fri 23-09-11 13:55:52, H Hartley Sweeten wrote:
> This quites the sparse noise:
>
> warning: symbol 'ext3_trim_all_free' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Thanks, merged into my tree.
Honza
>
> ---
>
> diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c
> index 6386d76..8e62ec5 100644
> --- a/fs/ext3/balloc.c
> +++ b/fs/ext3/balloc.c
> @@ -1924,9 +1924,10 @@ unsigned long ext3_bg_num_gdb(struct super_block *sb, int group)
> * reaches any used block. Then issue a TRIM command on this extent and free
> * the extent in the block bitmap. This is done until whole group is scanned.
> */
> -ext3_grpblk_t ext3_trim_all_free(struct super_block *sb, unsigned int group,
> - ext3_grpblk_t start, ext3_grpblk_t max,
> - ext3_grpblk_t minblocks)
> +static ext3_grpblk_t ext3_trim_all_free(struct super_block *sb,
> + unsigned int group,
> + ext3_grpblk_t start, ext3_grpblk_t max,
> + ext3_grpblk_t minblocks)
> {
> handle_t *handle;
> ext3_grpblk_t next, free_blocks, bit, freed, count = 0;
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-04 23:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-23 20:55 [PATCH] ext3/balloc.c: local functions should be static H Hartley Sweeten
2011-10-04 23:29 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®