mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Andreas Dilger <adilger.kernel@dilger.ca>,
	Herbert Xu <herbert@gondor.hengli.com.au>,
	Theodore Tso <tytso@mit.edu>, David Miller <davem@davemloft.net>,
	"Darrick J. Wong" <djwong@us.ibm.com>
Cc: Joakim Tjernlund <joakim.tjernlund@transmode.se>,
	Bob Pearson <rpearson@systemfabricworks.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Mingming Cao <cmm@us.ibm.com>,
	linux-crypto <linux-crypto@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	linux-ext4@vger.kernel.org
Subject: [PATCH v5 0/4] crc32c: Add faster algorithm and self-test code
Date: Tue, 04 Oct 2011 16:53:57 -0700	[thread overview]
Message-ID: <20111004235357.1560.12602.stgit@elm3c44.beaverton.ibm.com> (raw)

Hi all,

This patchset (re)uses Bob Pearson's crc32 slice-by-8 code to stamp out a
software crc32c implementation.  It requires that all ten of his patches (at
least the ones dated 31 Aug 2011) be applied.  It removes the crc32c
implementation in crypto/ in favor of using the stamped-out one in lib/.  There
is also a change to Kconfig so that the kernel builder can pick an
implementation best suited for the hardware.

The motivation for this patchset is that I am working on adding full metadata
checksumming to ext4.  As far as performance impact of adding checksumming
goes, I see nearly no change with a standard mail server ffsb simulation.  On a
test that involves only file creation and deletion and extent tree writes, I
see a drop of about 50 pcercent with the current kernel crc32c implementation;
this improves to a drop of about 20 percent with the enclosed crc32c code.

When metadata is usually a small fraction of total IO, this new implementation
doesn't help much because metadata is usually a small fraction of total IO.
However, when we are doing IO that is almost all metadata (such as rm -rf'ing a
tree), then this patch speeds up the operation substantially.

Incidentally, given that iscsi, sctp, and btrfs also use crc32c, this patchset
should improve their speed as well.  I have not yet quantified that, however.

--D

             reply	other threads:[~2011-10-04 23:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 23:53 Darrick J. Wong [this message]
2011-10-04 23:54 ` [PATCH 1/4] crc32: Bolt on crc32c Darrick J. Wong
2011-10-21 12:28   ` Herbert Xu
2011-10-21 16:57     ` Darrick J. Wong
2011-10-21 19:15       ` Herbert Xu
2011-10-26 17:16         ` Darrick J. Wong
2011-10-27 18:32           ` Time for a fresh slice-by-8 crc32.c posting? Darrick J. Wong
2011-11-15  8:48         ` [PATCH 1/4] crc32: Bolt on crc32c Darrick J. Wong
2011-11-15 15:38           ` Bob Pearson
2011-10-04 23:54 ` [PATCH 2/4] crypto: crc32c should use library implementation Darrick J. Wong
2011-10-04 23:54 ` [PATCH 3/4] crc32: Add self-test code for crc32c Darrick J. Wong
2011-10-04 23:54 ` [PATCH 4/4] crc32: Select an algorithm via kconfig Darrick J. Wong
2011-10-08  7:42   ` [PATCH v5.1 " Darrick J. Wong
2011-10-06 20:20 ` [PATCH v5 0/4] crc32c: Add faster algorithm and self-test code Darrick J. Wong
2011-10-07  7:38   ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111004235357.1560.12602.stgit@elm3c44.beaverton.ibm.com \
    --to=djwong@us.ibm.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=cmm@us.ibm.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.hengli.com.au \
    --cc=joakim.tjernlund@transmode.se \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpearson@systemfabricworks.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®