From: "Darrick J. Wong" <djwong@us.ibm.com>
To: Andreas Dilger <adilger.kernel@dilger.ca>,
Herbert Xu <herbert@gondor.hengli.com.au>,
Theodore Tso <tytso@mit.edu>, David Miller <davem@davemloft.net>
Cc: Joakim Tjernlund <joakim.tjernlund@transmode.se>,
Bob Pearson <rpearson@systemfabricworks.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Mingming Cao <cmm@us.ibm.com>,
linux-crypto <linux-crypto@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4@vger.kernel.org
Subject: [PATCH v5.1 4/4] crc32: Select an algorithm via kconfig
Date: Sat, 8 Oct 2011 00:42:07 -0700 [thread overview]
Message-ID: <20111008074207.GK12447@tux1.beaverton.ibm.com> (raw)
In-Reply-To: <20111004235429.1560.89556.stgit@elm3c44.beaverton.ibm.com>
Oops, the description of CRC32_SLICEBY4 is a bit screwy. Let's try that again.
---
Allow the kernel builder to choose a crc32* algorithm for the kernel.
Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
---
lib/Kconfig | 36 ++++++++++++++++++++++++++++++++++++
lib/crc32defs.h | 18 ++++++++++++++++++
2 files changed, 54 insertions(+), 0 deletions(-)
diff --git a/lib/Kconfig b/lib/Kconfig
index 477be04..27881d9 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -70,6 +70,42 @@ config CRC32_SELFTEST
and crc32_be over byte strings with random alignment and length
and computes the total elapsed time and number of bytes processed.
+choice
+ prompt "CRC32 implementation"
+ depends on CRC32
+ default CRC32_SLICEBY8
+
+config CRC32_SLICEBY8
+ bool "Slice by 8 bytes"
+ help
+ Calculate checksum 8 bytes at a time with a clever slicing algorithm.
+ This is the fastest algorithm, but comes with a 8KiB lookup table.
+ Most modern processors have enough cache that this shouldn't be
+ a problem.
+
+ If you don't know which to choose, choose this one.
+
+config CRC32_SLICEBY4
+ bool "Slice by 4 bytes"
+ help
+ Calculate checksum 4 bytes at a time with a clever slicing algorithm.
+ This is a bit slower than slice by 8, but has a smaller 4KiB lookup
+ table.
+
+config CRC32_SARWATE
+ bool "Sarwate's Algorithm (one byte at a time)"
+ help
+ Calculate checksum a byte at a time using Sarwate's algorithm. This
+ is not particularly fast, but has a small 256 byte lookup table.
+
+config CRC32_BIT
+ bool "Classic Algorithm (one bit at a time)"
+ help
+ Calculate checksum one bit at a time. This is VERY slow, but has
+ no lookup table. This is provided as a debugging option.
+
+endchoice
+
config CRC7
tristate "CRC7 functions"
help
diff --git a/lib/crc32defs.h b/lib/crc32defs.h
index 6fd1917..64cba2c 100644
--- a/lib/crc32defs.h
+++ b/lib/crc32defs.h
@@ -13,6 +13,24 @@
*/
#define CRC32C_POLY_LE 0x82F63B78
+/* Try to choose an implementation variant via Kconfig */
+#ifdef CONFIG_CRC32_SLICEBY8
+# define CRC_LE_BITS 64
+# define CRC_BE_BITS 64
+#endif
+#ifdef CONFIG_CRC32_SLICEBY4
+# define CRC_LE_BITS 32
+# define CRC_BE_BITS 32
+#endif
+#ifdef CONFIG_CRC32_SARWATE
+# define CRC_LE_BITS 8
+# define CRC_BE_BITS 8
+#endif
+#ifdef CONFIG_CRC32_BIT
+# define CRC_LE_BITS 1
+# define CRC_BE_BITS 1
+#endif
+
/*
* How many bits at a time to use. Valid values are 1, 2, 4, 8, 32 and 64.
* For less performance-sensitive, use 4 or 8 to save table size.
next prev parent reply other threads:[~2011-10-08 7:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-04 23:53 [PATCH v5 0/4] crc32c: Add faster algorithm and self-test code Darrick J. Wong
2011-10-04 23:54 ` [PATCH 1/4] crc32: Bolt on crc32c Darrick J. Wong
2011-10-21 12:28 ` Herbert Xu
2011-10-21 16:57 ` Darrick J. Wong
2011-10-21 19:15 ` Herbert Xu
2011-10-26 17:16 ` Darrick J. Wong
2011-10-27 18:32 ` Time for a fresh slice-by-8 crc32.c posting? Darrick J. Wong
2011-11-15 8:48 ` [PATCH 1/4] crc32: Bolt on crc32c Darrick J. Wong
2011-11-15 15:38 ` Bob Pearson
2011-10-04 23:54 ` [PATCH 2/4] crypto: crc32c should use library implementation Darrick J. Wong
2011-10-04 23:54 ` [PATCH 3/4] crc32: Add self-test code for crc32c Darrick J. Wong
2011-10-04 23:54 ` [PATCH 4/4] crc32: Select an algorithm via kconfig Darrick J. Wong
2011-10-08 7:42 ` Darrick J. Wong [this message]
2011-10-06 20:20 ` [PATCH v5 0/4] crc32c: Add faster algorithm and self-test code Darrick J. Wong
2011-10-07 7:38 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111008074207.GK12447@tux1.beaverton.ibm.com \
--to=djwong@us.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=cmm@us.ibm.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpearson@systemfabricworks.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®