From: Dan Carpenter <dan.carpenter@oracle.com>
To: JAke Burton <jake5991@live.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org,
fmhess@users.sourceforge.net, abbotti@mev.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: fix brace coding and whitespace issue in ni_atmio.c
Date: Sun, 9 Oct 2011 01:05:40 +0300 [thread overview]
Message-ID: <20111008215930.GM18470@longonot.mountain> (raw)
In-Reply-To: <BLU0-SMTP9072E77C5346BC9ADCE223A2FF0@phx.gbl>
Nah. For this kind of thing you need to redo the first one, not
just write another patch on top of it. The v2 patch should have a
subject with [patch v2] blah blah blah. After the Signed-off-by line
put three dashes "---" and then the changes between v1 and v2.
Signed-off-by: you
---
v2: whitespace changes for Joe Perches.
Joe should be added to the CC list. Hopefully it should be sent in
the same thread as a response to Joe's email. Use the In-Reply-To
header.
Also the "};" on the first hunk should be moved down a line as well.
And the subject and the commit message on the first patch were
mangled. There wasn't a blank line after the Subject and before the
changelog. It need another blank line in front of the Signed-off-by
line and this patch doesn't have a Signed-off-by line. (These things
matter because the process is scripted).
If you want you can leave linux-kernel off the CC list. They don't
care about whitespace patches to staging.
regards,
dan carpenter
prev parent reply other threads:[~2011-10-08 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-08 19:58 JAke Burton
2011-10-08 22:05 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111008215930.GM18470@longonot.mountain \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=jake5991@live.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®