[PATCH 2/2] Staging: comedi: fix brace coding and whitespace issue in ni_atmio.c

[PATCH 2/2] Staging: comedi: fix brace coding and whitespace issue in ni_atmio.c

[JAke Burton]

---
 drivers/staging/comedi/drivers/ni_atmio.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c
index e6c6c72..91e270a 100644
--- a/drivers/staging/comedi/drivers/ni_atmio.c
+++ b/drivers/staging/comedi/drivers/ni_atmio.c
@@ -279,7 +279,9 @@ static const int ni_irqpin[] = {
 
 struct ni_private {
 	struct pnp_dev *isapnp_dev;
-NI_PRIVATE_COMMON};
+	NI_PRIVATE_COMMON
+};
+
 #define devpriv ((struct ni_private *)dev->private)
 
 /* How we access registers */
-- 
1.7.4.1

Re: [PATCH 2/2] Staging: comedi: fix brace coding and whitespace issue in ni_atmio.c

[Dan Carpenter]

Nah.  For this kind of thing you need to redo the first one, not
just write another patch on top of it.  The v2 patch should have a
subject with [patch v2] blah blah blah.  After the Signed-off-by line
put three dashes "---" and then the changes between v1 and v2.

Signed-off-by:  you
---
v2:  whitespace changes for Joe Perches.

Joe should be added to the CC list.  Hopefully it should be sent in
the same thread as a response to Joe's email.  Use the In-Reply-To
header.

Also the "};" on the first hunk should be moved down a line as well.

And the subject and the commit message on the first patch were
mangled.  There wasn't a blank line after the Subject and before the
changelog.  It need another blank line in front of the Signed-off-by
line and this patch doesn't have a Signed-off-by line.  (These things
matter because the process is scripted).

If you want you can leave linux-kernel off the CC list.  They don't
care about whitespace patches to staging.

regards,
dan carpenter