From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] pata_sil680: minor CodingStyle fixups
Date: Wed, 12 Oct 2011 12:03:05 +0100 [thread overview]
Message-ID: <20111012120305.0b5f8f06@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4E957080.6020102@mvista.com>
>
> > + /* This last case is _NOT_ ok */
> > + case 0x30:
> > + printk(KERN_ERR "sil680: Clock disabled ?\n");
>
> pr_err()? Or checkpatch.pl doesn't complain about it (I forgot)?
dev_ would be even better but that seems to be a separate thing. The
existing patch is still a move in the right direction.
next prev parent reply other threads:[~2011-10-12 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 18:21 Bartlomiej Zolnierkiewicz
2011-10-11 19:47 ` Alan Cox
2011-10-12 10:48 ` Sergei Shtylyov
2011-10-12 11:03 ` Alan Cox [this message]
2011-10-14 16:45 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111012120305.0b5f8f06@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®