* [PATCH 1/1] hpsa: change confusing comment to more clear
@ 2011-10-13 16:44 Mike Miller
0 siblings, 0 replies; only message in thread
From: Mike Miller @ 2011-10-13 16:44 UTC (permalink / raw)
To: James Bottomley; +Cc: thenzl, LKML, LKML-scsi, scameron
Patch 1 of 1
hpsa: clarify comment in kdump reset code
From: Mike Miller <mike.miller@hp.com>
The following warning message may be confusing to some users:
dev_warn(&pdev->dev, "Controller claims that "
"'Bit 2 doorbell reset' is "
"supported, but not 'bit 5 doorbell reset'. "
"Firmware update is recommended.\n");
Most users don't know or care what bit we may be hitting. Also change
"recommended" to "required."
Signed-off-by: Mike Miller <mike.miller@hp.com>
---
drivers/scsi/hpsa.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 311bf7a..f7a569e 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3450,10 +3450,8 @@ static __devinit int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev)
} else {
use_doorbell = misc_fw_support & MISC_FW_DOORBELL_RESET;
if (use_doorbell) {
- dev_warn(&pdev->dev, "Controller claims that "
- "'Bit 2 doorbell reset' is "
- "supported, but not 'bit 5 doorbell reset'. "
- "Firmware update is recommended.\n");
+ dev_warn(&pdev->dev, "Soft reset not supported. "
+ "Firmware update is required.\n");
rc = -ENOTSUPP; /* try soft reset */
goto unmap_cfgtable;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-10-13 16:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-13 16:44 [PATCH 1/1] hpsa: change confusing comment to more clear Mike Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome