mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Godmar Back <godmar@gmail.com>,
	linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>
Subject: Re: Q.: Why does tty_ioctl.c: set_termios return EINTR instead of ERESTARTSYS?
Date: Sat, 15 Oct 2011 10:25:59 +0100	[thread overview]
Message-ID: <20111015102559.3e85b32d@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4E994A65.7000509@suse.cz>

 Is there a particular reason why it cannot be made restartable?
> 
> EINTR is used when there is no way to rollback already performed
> actions. In this case, a flush could be performed. (This holds only for
> TCSETSF, TCSETSF2 and similar.) So I think this is the reason we cannot
> return ERESTARTSYS.
> 
> However I CCed tty fellows, they may have a different opinion.

I don't actually know. I think Linus or Ted T'so were still doing the tty
code that long back. Ted also did some compliance testing on it way back
when (1995 or so ?)

  reply	other threads:[~2011-10-15  9:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAB4+JYLiF4wr+U5s_m15baC=Ktf8NnAYFKfcyhM3AxG9PZ4YPA@mail.gmail.com>
     [not found] ` <CAB4+JYJYVFouMYZMX4bGVA+vPm1rD3KY3GvwVjKBZS7bwf6-zQ@mail.gmail.com>
2011-10-14 16:52   ` Godmar Back
2011-10-15  8:55     ` Jiri Slaby
2011-10-15  9:25       ` Alan Cox [this message]
2011-10-15 13:12       ` Godmar Back

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111015102559.3e85b32d@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=godmar@gmail.com \
    --cc=gregkh@suse.de \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®