* [PATCH v2] PM: fix runtime accounting calculation error
@ 2011-10-28 8:45 vbyravarasu
2011-10-28 11:51 ` Rafael J. Wysocki
2011-11-03 0:18 ` Rafael J. Wysocki
0 siblings, 2 replies; 4+ messages in thread
From: vbyravarasu @ 2011-10-28 8:45 UTC (permalink / raw)
To: pavel, rjw, len.brown, gregkh
Cc: linux-pm, linux-kernel, vbyravarasu, pdeschrijver
From: venu byravarasu <vbyravarasu@nvidia.com>
With delta type being int, its value is made zero
for all values of now > 0x80000000.
Hence fixing it.
Signed-off-by: venu byravarasu <vbyravarasu@nvidia.com>
---
changes since v1:
Removed max_num and its usage references.
..........
drivers/base/power/runtime.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
index 1079e03..e8a5172 100644
--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -30,13 +30,10 @@ static int rpm_suspend(struct device *dev, int rpmflags);
void update_pm_runtime_accounting(struct device *dev)
{
unsigned long now = jiffies;
- int delta;
+ unsigned long delta;
delta = now - dev->power.accounting_timestamp;
- if (delta < 0)
- delta = 0;
-
dev->power.accounting_timestamp = now;
if (dev->power.disable_depth > 0)
--
1.7.1.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] PM: fix runtime accounting calculation error
2011-10-28 8:45 [PATCH v2] PM: fix runtime accounting calculation error vbyravarasu
@ 2011-10-28 11:51 ` Rafael J. Wysocki
2011-11-03 0:18 ` Rafael J. Wysocki
1 sibling, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2011-10-28 11:51 UTC (permalink / raw)
To: vbyravarasu
Cc: pavel, len.brown, gregkh, linux-pm, linux-kernel, pdeschrijver
On Friday, October 28, 2011, vbyravarasu@nvidia.com wrote:
> From: venu byravarasu <vbyravarasu@nvidia.com>
>
> With delta type being int, its value is made zero
> for all values of now > 0x80000000.
> Hence fixing it.
>
> Signed-off-by: venu byravarasu <vbyravarasu@nvidia.com>
Thanks, looks good. I'll add it to the linux-pm tree's pm-fixes
branch when I'm back home later this week.
Rafael
> ---
> changes since v1:
> Removed max_num and its usage references.
> ..........
>
> drivers/base/power/runtime.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
> index 1079e03..e8a5172 100644
> --- a/drivers/base/power/runtime.c
> +++ b/drivers/base/power/runtime.c
> @@ -30,13 +30,10 @@ static int rpm_suspend(struct device *dev, int rpmflags);
> void update_pm_runtime_accounting(struct device *dev)
> {
> unsigned long now = jiffies;
> - int delta;
> + unsigned long delta;
>
> delta = now - dev->power.accounting_timestamp;
>
> - if (delta < 0)
> - delta = 0;
> -
> dev->power.accounting_timestamp = now;
>
> if (dev->power.disable_depth > 0)
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] PM: fix runtime accounting calculation error
2011-10-28 8:45 [PATCH v2] PM: fix runtime accounting calculation error vbyravarasu
2011-10-28 11:51 ` Rafael J. Wysocki
@ 2011-11-03 0:18 ` Rafael J. Wysocki
2011-11-03 3:17 ` Venu Byravarasu
1 sibling, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2011-11-03 0:18 UTC (permalink / raw)
To: vbyravarasu
Cc: pavel, len.brown, gregkh, linux-pm, linux-kernel, pdeschrijver
On Friday, October 28, 2011, vbyravarasu@nvidia.com wrote:
> From: venu byravarasu <vbyravarasu@nvidia.com>
>
> With delta type being int, its value is made zero
> for all values of now > 0x80000000.
> Hence fixing it.
>
> Signed-off-by: venu byravarasu <vbyravarasu@nvidia.com>
Applied to linux-pm/linux-next.
Thanks,
Rafael
> ---
> changes since v1:
> Removed max_num and its usage references.
> ..........
>
> drivers/base/power/runtime.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
> index 1079e03..e8a5172 100644
> --- a/drivers/base/power/runtime.c
> +++ b/drivers/base/power/runtime.c
> @@ -30,13 +30,10 @@ static int rpm_suspend(struct device *dev, int rpmflags);
> void update_pm_runtime_accounting(struct device *dev)
> {
> unsigned long now = jiffies;
> - int delta;
> + unsigned long delta;
>
> delta = now - dev->power.accounting_timestamp;
>
> - if (delta < 0)
> - delta = 0;
> -
> dev->power.accounting_timestamp = now;
>
> if (dev->power.disable_depth > 0)
>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH v2] PM: fix runtime accounting calculation error
2011-11-03 0:18 ` Rafael J. Wysocki
@ 2011-11-03 3:17 ` Venu Byravarasu
0 siblings, 0 replies; 4+ messages in thread
From: Venu Byravarasu @ 2011-11-03 3:17 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: pavel, len.brown, gregkh, linux-pm, linux-kernel, Peter De Schrijver
-----Original Message-----
> From: Rafael J. Wysocki [mailto:rjw@sisk.pl]
> Sent: Thursday, November 03, 2011 5:49 AM
> To: Venu Byravarasu
> Cc: pavel@ucw.cz; len.brown@intel.com; gregkh@suse.de; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org; Peter De Schrijver
> Subject: Re: [PATCH v2] PM: fix runtime accounting calculation error
>
> On Friday, October 28, 2011, vbyravarasu@nvidia.com wrote:
> > From: venu byravarasu <vbyravarasu@nvidia.com>
> >
> > With delta type being int, its value is made zero
> > for all values of now > 0x80000000.
> > Hence fixing it.
> >
> > Signed-off-by: venu byravarasu <vbyravarasu@nvidia.com>
>
> Applied to linux-pm/linux-next.
Thanks Rafael.
Venu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-03 3:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-28 8:45 [PATCH v2] PM: fix runtime accounting calculation error vbyravarasu
2011-10-28 11:51 ` Rafael J. Wysocki
2011-11-03 0:18 ` Rafael J. Wysocki
2011-11-03 3:17 ` Venu Byravarasu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®