From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: tony@atomide.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] net: Add back alignment for size for __alloc_skb
Date: Wed, 02 Nov 2011 19:09:55 -0400 (EDT) [thread overview]
Message-ID: <20111102.190955.1902322759075682192.davem@davemloft.net> (raw)
In-Reply-To: <4EB1CA4F.3090403@gmail.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 02 Nov 2011 23:55:11 +0100
> There is a problem with your kmalloc() or alignments on your architecture.
>
> What is the SMP_CACHE_BYTES value ?
kmalloc() behavior doesn't have anything to do with this bug.
The issue is calculation of skb->end, which is based upon calculated
'size' variable.
skb->end determines alignment of skb_shared_info, which is where the
alignment problem is occuring for Tony.
next prev parent reply other threads:[~2011-11-02 23:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 22:43 Tony Lindgren
2011-11-02 22:55 ` Eric Dumazet
2011-11-02 23:09 ` David Miller [this message]
2011-11-02 23:13 ` David Miller
2011-11-02 23:14 ` Eric Dumazet
2011-11-02 23:17 ` David Miller
2011-11-02 23:19 ` Tony Lindgren
2011-11-02 23:20 ` Eric Dumazet
2011-11-02 23:24 ` Tony Lindgren
2011-11-02 23:31 ` Eric Dumazet
2011-11-02 23:40 ` Tony Lindgren
2011-11-03 22:09 ` David Miller
2011-11-02 23:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111102.190955.1902322759075682192.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®