[GIT PULL 0/2] perf/core fixes

[GIT PULL 0/2] perf/core fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please consider pulling from:

git://github.com/acmel/linux.git perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (2):
  perf top tui: Don't recalc column widths considering just the first page
  perf top: Fix live annotation in the --stdio interface

 tools/perf/builtin-top.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 1/2] perf top tui: Don't recalc column widths considering just the first page

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

It makes sense for the stdio where we can't navigate to the other pages.

On the TUI it breaks as soon as we navigate to other pages that have,
DSOs with longer names than the ones on the first page.

Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-zvqfp18mw229agb43cikgb0k@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-top.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index 8577bfe..a13f887 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -564,7 +564,6 @@ static void perf_top__sort_new_samples(void *arg)
 	hists__decay_entries_threaded(&t->sym_evsel->hists,
 				      top.hide_user_symbols,
 				      top.hide_kernel_symbols);
-	hists__output_recalc_col_len(&t->sym_evsel->hists, winsize.ws_row - 3);
 }
 
 static void *display_thread_tui(void *arg __used)
-- 
1.6.2.5

[PATCH 2/2] perf top: Fix live annotation in the --stdio interface

[Arnaldo Carvalho de Melo]

From: Arnaldo Carvalho de Melo <acme@redhat.com>

In the old --stdio interface the annotation is done just after one
selects a symbol, while in --tui, now the default when the required libs
are installed, we annotate all symbols with samples so that when
annotation is asked we see what happened recently on that symbol.

To achieve that the --stdio variant checks if the hist_entry being
processed is the one selected by the user via the 's' hotkey. What
happens now that we share the hist_entry abstractions with 'perf report'
is that for minimizing locking contention multiple rb_trees are used,
one for collecting the samples and other to browse/show them after
resorting it by number of samples and decay them, which is done
periodically.

So the simple test in record_precise_ip doesn't work as we move
hist_entries between those rb_trees. To fix it just check that the
underlying struct symbol associated with those hist_entries is the same.

Reported-by: Mike Galbraith <efault@gmx.de>
Tested-by: Mike Galbraith <efault@gmx.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-bcfnraqkux88fox9ba9767ds@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-top.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index a13f887..c9cdedb 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -200,7 +200,8 @@ static void record_precise_ip(struct hist_entry *he, int counter, u64 ip)
 	struct symbol *sym;
 
 	if (he == NULL || he->ms.sym == NULL ||
-	    (he != top.sym_filter_entry && use_browser != 1))
+	    ((top.sym_filter_entry == NULL ||
+	      top.sym_filter_entry->ms.sym != he->ms.sym) && use_browser != 1))
 		return;
 
 	sym = he->ms.sym;
-- 
1.6.2.5

Re: [GIT PULL 0/2] perf/core fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please consider pulling from:
> 
> git://github.com/acmel/linux.git perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (2):
>   perf top tui: Don't recalc column widths considering just the first page
>   perf top: Fix live annotation in the --stdio interface
> 
>  tools/perf/builtin-top.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Pulled into tip:perf/urgent, thanks a lot Arnaldo!

	Ingo

Re: [GIT PULL 0/2] perf/core fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
> 	Please consider pulling, on top of the previous req,
> 
> - Arnaldo
> 
> The following changes since commit b1ac754b67b5a875d63bee880f60ccb0c6bd8899:
> 
>   tools lib traceevent: Handle alloc_arg failure (2012-09-24 12:31:52 -0300)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo
> 
> for you to fetch changes up to f1b2256d66fe8d613b9afcc1c16079362f9fc05c:
> 
>   tools lib traceevent: Fix error path on pevent_parse_event (2012-09-25 09:53:53 -0300)
> 
> ----------------------------------------------------------------
> perf/core fixes:
> 
> . The new perf_evsel__tp_sched_test 'perf test' broke the build by setting the
>   'ret' variable but not using it, caught by newer gcc
>   -Werror=unused-but-set-variable, fix from Namhyung Kim.
> 
> . pevent_parse_event should return a proper PEVENT_ERRNO__ and call
>   pevent_free_format on its failure path, fixes from Namhyung Kim.
> 
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> ----------------------------------------------------------------
> Namhyung Kim (2):
>       perf test: Fix build failure
>       tools lib traceevent: Fix error path on pevent_parse_event
> 
>  tools/lib/traceevent/event-parse.c |    8 ++++----
>  tools/perf/builtin-test.c          |    4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)

Pulled, thanks Arnaldo!

	Ingo

[GIT PULL 0/2] perf/core fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

	Please consider pulling, on top of the previous req,

- Arnaldo

The following changes since commit b1ac754b67b5a875d63bee880f60ccb0c6bd8899:

  tools lib traceevent: Handle alloc_arg failure (2012-09-24 12:31:52 -0300)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux tags/perf-core-for-mingo

for you to fetch changes up to f1b2256d66fe8d613b9afcc1c16079362f9fc05c:

  tools lib traceevent: Fix error path on pevent_parse_event (2012-09-25 09:53:53 -0300)

----------------------------------------------------------------
perf/core fixes:

. The new perf_evsel__tp_sched_test 'perf test' broke the build by setting the
  'ret' variable but not using it, caught by newer gcc
  -Werror=unused-but-set-variable, fix from Namhyung Kim.

. pevent_parse_event should return a proper PEVENT_ERRNO__ and call
  pevent_free_format on its failure path, fixes from Namhyung Kim.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Namhyung Kim (2):
      perf test: Fix build failure
      tools lib traceevent: Fix error path on pevent_parse_event

 tools/lib/traceevent/event-parse.c |    8 ++++----
 tools/perf/builtin-test.c          |    4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

[GIT PULL 0/2] perf/core fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please consider pulling from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

	Mike, this fixes a segfault when navigating in the tail of the active
list in perf top --tui.

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (1):
  perf top browser: Adjust the browser indexes when refreshing

Marcin Slusarz (1):
  perf lock: Document valid sort keys

 tools/perf/Documentation/perf-lock.txt |   12 ++++++++++--
 tools/perf/builtin-lock.c              |    2 +-
 tools/perf/util/ui/browsers/top.c      |   23 +++++++++++++++++++++++
 3 files changed, 34 insertions(+), 3 deletions(-)

Re: [GIT PULL 0/2] perf/core fixes

[Ingo Molnar]

* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> Hi Ingo,
> 
>         Please consider pulling from:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core
> 
> Regards,
> 
> - Arnaldo
> 
> Arnaldo Carvalho de Melo (2):
>   perf probe: Fix error propagation leading to segfault
>   perf evsel: Fix inverted test for fixing up attr.inherit flag
> 
>  tools/perf/util/evsel.c        |   15 +++++++++++++--
>  tools/perf/util/probe-event.c  |    5 ++++-
>  tools/perf/util/probe-finder.c |    4 +++-
>  3 files changed, 20 insertions(+), 4 deletions(-)

Pulled, thanks a lot Arnaldo!

Thanks,

	Ingo

[GIT PULL 0/2] perf/core fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please consider pulling from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

Regards,

- Arnaldo

Arnaldo Carvalho de Melo (2):
  perf probe: Fix error propagation leading to segfault
  perf evsel: Fix inverted test for fixing up attr.inherit flag

 tools/perf/util/evsel.c        |   15 +++++++++++++--
 tools/perf/util/probe-event.c  |    5 ++++-
 tools/perf/util/probe-finder.c |    4 +++-
 3 files changed, 20 insertions(+), 4 deletions(-)

[GIT PULL 0/2] perf/core fixes

[Arnaldo Carvalho de Melo]

Hi Ingo,

        Please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux-2.6 perf/core

	Now there are 13 outstanding patches in this branch.

Regards,

- Arnaldo

Corey Ashford (1):
  perf tools: fix event parsing of comma-separated tracepoint events

Don Zickus (1):
  perf packaging: add memcpy to perf MANIFEST

 tools/perf/MANIFEST            |    1 +
 tools/perf/util/parse-events.c |   12 ++++++++----
 2 files changed, 9 insertions(+), 4 deletions(-)