mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Ilya Zykov <ilya@ilyx.ru>, Alan Cox <alan@linux.intel.com>,
	linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
	Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH v3 2/2] TTY: tty flip buffer optimisation.
Date: Mon, 14 Nov 2011 15:05:23 +0000	[thread overview]
Message-ID: <20111114150523.2abdf7a1@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4EC124EB.4050203@suse.cz>

> Hi, the results are indeed nice. However is there any *real* load other
> than this tailor-made microbenchmark where the added code complexity is
> worth it?

I'm wondering if we need the complexity in the first place. Certainly 256
does seem a bit small for pty/tty traffic. A 'real world' benchmark would
be an ls -lR / on a machine with a fast graphics card or in console mode

ie

ls -lR /		# prime cache
time ls -lR /

and there are cases where people do a lot of traffic over a pty like this
so I don't think it's entirely fake.

I don't like the complexity but we could certainly go from using 256 byte
buffers to "tty->buf.bufsize" and make it configurable without
that complexity.

Alan

  reply	other threads:[~2011-11-14 15:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14 12:47 Ilya Zykov
2011-11-14 14:25 ` Jiri Slaby
2011-11-14 15:05   ` Alan Cox [this message]
2011-11-14 15:47     ` Ilya Zykov
2011-11-14 16:08       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111114150523.2abdf7a1@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=ilya@ilyx.ru \
    --cc=jirislaby@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®