From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Ilya Zykov <ilya@ilyx.ru>
Cc: Jiri Slaby <jslaby@suse.cz>, Alan Cox <alan@linux.intel.com>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Jiri Slaby <jirislaby@gmail.com>
Subject: Re: [PATCH v3 2/2] TTY: tty flip buffer optimisation.
Date: Mon, 14 Nov 2011 16:08:14 +0000 [thread overview]
Message-ID: <20111114160814.2f9de9a9@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4EC137F6.1050509@ilyx.ru>
> For avoid complexity we need remove free buffer at all.
> And use kmalloc()-kfree() for every chunk. Don't need tty_buffer_find().
> It will be fast and easy.
The buffer cycling was added because it speeds up some cases (as you
found), and because its needed for high speed serial on some very low end
devices. From your benchmarks it's also speeding up pty/tty so it's
clearly relevant.
Alan
prev parent reply other threads:[~2011-11-14 16:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 12:47 Ilya Zykov
2011-11-14 14:25 ` Jiri Slaby
2011-11-14 15:05 ` Alan Cox
2011-11-14 15:47 ` Ilya Zykov
2011-11-14 16:08 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114160814.2f9de9a9@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=ilya@ilyx.ru \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®