Re: [PATCH] Drivers: hwmon: it87: Add support for ITE 8728

Re: [PATCH] Drivers: hwmon: it87: Add support for ITE 8728

[Guenter Roeck]

On Fri, 2011-11-04 at 00:44 -0400, Frank T. Lofaro Jr. wrote:
> This patch allows the ITE 8728 chip to be detected and used.
> The chip appears to be compatible with the 8721.
> 

Can anyone confirm that those chips are actually compatible ?

Thanks,
Guenter

Signed-off-by: Frank T. Lofaro Jr. <ftlofaro@yahoo.com>
> ---
>  drivers/hwmon/it87.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hwmon/it87.c b/drivers/hwmon/it87.c
> index d912649..0b21d18 100644
> --- a/drivers/hwmon/it87.c
> +++ b/drivers/hwmon/it87.c
> @@ -17,6 +17,7 @@
>   *            IT8720F  Super I/O chip w/LPC interface
>   *            IT8721F  Super I/O chip w/LPC interface
>   *            IT8726F  Super I/O chip w/LPC interface
> + *            IT8728F  Super I/O chip w/LPC interface
>   *            IT8758E  Super I/O chip w/LPC interface
>   *            Sis950   A clone of the IT8705F
>   *
> @@ -135,6 +136,7 @@ static inline void superio_exit(void)
>  #define IT8720F_DEVID 0x8720
>  #define IT8721F_DEVID 0x8721
>  #define IT8726F_DEVID 0x8726
> +#define IT8728F_DEVID 0x8728
>  #define IT87_ACT_REG  0x30
>  #define IT87_BASE_REG 0x60
>  
> @@ -1603,6 +1605,7 @@ static int __init it87_find(unsigned short
> *address,
>                 sio_data->type = it8720;
>                 break;
>         case IT8721F_DEVID:
> +       case IT8728F_DEVID:
>                 sio_data->type = it8721;
>                 break;
>         case 0xffff:    /* No device at all */
> -- 
> 1.7.7.2
> 
> 

Re: [PATCH] Drivers: hwmon: it87: Add support for ITE 8728

[Jean Delvare]

On Mon, 7 Nov 2011 10:00:45 -0800, Guenter Roeck wrote:
> On Fri, 2011-11-04 at 00:44 -0400, Frank T. Lofaro Jr. wrote:
> > This patch allows the ITE 8728 chip to be detected and used.
> > The chip appears to be compatible with the 8721.

Frank, can we see the output of "sensors" on your system with your
patch applied?

> Can anyone confirm that those chips are actually compatible ?

The datasheet is not publicly available, unfortunately. The info I have
is that temperature and fan parts are likely to be compatible. Not so
sure about the voltages, although the ADC resolution is the same (12
mV.)

> > @@ -1603,6 +1605,7 @@ static int __init it87_find(unsigned short
> > *address,
> >                 sio_data->type = it8720;
> >                 break;
> >         case IT8721F_DEVID:
> > +       case IT8728F_DEVID:
> >                 sio_data->type = it8721;
> >                 break;
> >         case 0xffff:    /* No device at all */

One thing for sure: I want to play it safe and introduce a separate
chip type for the IT8728F. Two advantages: we can tell who has an
IT8728F from user reports easily, and we can add chip tweaks later
easily without breaking user configurations.

-- 
Jean Delvare