mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Marc Vertes <marc.vertes@sigfox.com>
Cc: broonie@opensource.wolfsonmicro.com, wim@iguana.be,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	HaraldWelte@viatech.com
Subject: Re: [PATCH RFC] watchdog: add a new driver for VIA chipsets
Date: Wed, 23 Nov 2011 11:49:26 +0100	[thread overview]
Message-ID: <20111123104926.GB4063@pengutronix.de> (raw)
In-Reply-To: <4eccc3f0.iApQ//mCzaN3UsrB%marc.vertes@sigfox.com>

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

(BTW I removed a few duplicates from the CC list)

> A question regarding "nowayout", in the case of this VIA chipset where
> a watchdog can not be stopped once started from BIOS. I think I should
> set unconditionally WDOG_NO_WAY_OUT in status, shouldn't I ?
> 
> I also do not think it is correct to implement a timer and ping
> proactively in case of magicclose because 1) it complicates a bit the
> code, 2) there is no way to know the timeout value, and it set very low
> in the BIOS (1 s).

Yup, I'd accept the reason that you can't know the timeout value and
then setting NO_WAY_OUT unconditionally looks like the thing to do here.

@Wim: Would you accept drivers which can only ping a watchdog but
neither start/stop it?

@Marc: If he does, would you be interested in updating the watchdog-core
so that no start()/stop() will also be accepted if there is a ping()?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2011-11-23 10:49 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22 11:17 Marc Vertes
2011-11-22 11:22 ` Wolfram Sang
2011-11-22 12:56   ` Rahul Bedarkar
2011-11-22 17:05   ` Marc Vertes
2011-11-22 17:30     ` Wolfram Sang
2011-11-22 18:09       ` Marc Vertes
2011-11-22 18:55         ` Marc Vertes
2011-11-23 12:10           ` Dmitry Artamonow
2011-11-23 14:12             ` Marc Vertes
2011-11-23 14:37               ` Mark Brown
2011-11-23 19:25               ` Dmitry Artamonow
2011-11-23 21:43                 ` Wolfram Sang
2011-11-23 18:22             ` Harald Welte
2011-11-23 21:41               ` Wim Van Sebroeck
2011-11-24 19:22                 ` Marc Vertes
2011-11-24 19:34                   ` Wim Van Sebroeck
2011-11-25 20:02                     ` Marc Vertes
2011-11-22 17:32     ` Mark Brown
2011-11-22 18:40       ` Wolfram Sang
2011-11-23  9:59         ` Marc Vertes
2011-11-23 10:49           ` Wolfram Sang [this message]
2011-11-23 11:43             ` Marc Vertes
2011-11-23 12:13             ` Wim Van Sebroeck
2011-11-23 12:20               ` Mark Brown
2011-11-23 12:40                 ` Wim Van Sebroeck
2011-11-23 14:46                   ` Marc Vertes
2011-11-23 21:43                     ` Wim Van Sebroeck
2011-11-23 21:52                       ` Wolfram Sang
2011-11-24  8:29                         ` Wim Van Sebroeck
2011-11-23 21:46                     ` Wim Van Sebroeck
2011-11-24 10:57                       ` Marc Vertes
2011-11-24 13:42                         ` Wim Van Sebroeck
2011-11-24 14:42                           ` Marc Vertes
2011-11-24 15:48                             ` Wim Van Sebroeck
2011-11-24 16:47                               ` Marc Vertes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111123104926.GB4063@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=HaraldWelte@viatech.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=marc.vertes@sigfox.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®