mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wim Van Sebroeck <wim@iguana.be>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Wolfram Sang <w.sang@pengutronix.de>,
	Marc Vertes <marc.vertes@sigfox.com>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	HaraldWelte@viatech.com
Subject: Re: [PATCH RFC] watchdog: add a new driver for VIA chipsets
Date: Wed, 23 Nov 2011 13:40:37 +0100	[thread overview]
Message-ID: <20111123124037.GN23376@infomag.iguana.be> (raw)
In-Reply-To: <20111123122018.GA12227@opensource.wolfsonmicro.com>

Hi Marc,

> > Bottom line: Yes, there is hardware available that can only be pinged
> > and not be stopped, but No, Userspace needs the start/stop and ping
> > functionality so that a watchdog daemon can work correctly (which is
> > important because some watchdog daemons also do application testing.
> 
> Right, but if the hardware doesn't support this functionality it seems
> better to have the core deal with this rather than requiring the driver
> to implement empty operations.

As said, should indeed become part of the core, but the core needs to be
able to handle multiple devices and then this becomes more complex (because
some devices need and and other's don't).

Coming back to now: if the driver incorporates the timer (like all other
devices that can be started but not stopped once started do), then the start
and stop functions are not empty.
The timer (with the example that I prepared as part of the generic code) is
not so difficult and will be a good solution for the time being. (Unless
Dmitry Artamonow's comment about the fact that the watchdog could perhaps
be started and stopped is correct... This should be investigated first imho).

Kind regards,
Wim.


  reply	other threads:[~2011-11-23 12:43 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22 11:17 Marc Vertes
2011-11-22 11:22 ` Wolfram Sang
2011-11-22 12:56   ` Rahul Bedarkar
2011-11-22 17:05   ` Marc Vertes
2011-11-22 17:30     ` Wolfram Sang
2011-11-22 18:09       ` Marc Vertes
2011-11-22 18:55         ` Marc Vertes
2011-11-23 12:10           ` Dmitry Artamonow
2011-11-23 14:12             ` Marc Vertes
2011-11-23 14:37               ` Mark Brown
2011-11-23 19:25               ` Dmitry Artamonow
2011-11-23 21:43                 ` Wolfram Sang
2011-11-23 18:22             ` Harald Welte
2011-11-23 21:41               ` Wim Van Sebroeck
2011-11-24 19:22                 ` Marc Vertes
2011-11-24 19:34                   ` Wim Van Sebroeck
2011-11-25 20:02                     ` Marc Vertes
2011-11-22 17:32     ` Mark Brown
2011-11-22 18:40       ` Wolfram Sang
2011-11-23  9:59         ` Marc Vertes
2011-11-23 10:49           ` Wolfram Sang
2011-11-23 11:43             ` Marc Vertes
2011-11-23 12:13             ` Wim Van Sebroeck
2011-11-23 12:20               ` Mark Brown
2011-11-23 12:40                 ` Wim Van Sebroeck [this message]
2011-11-23 14:46                   ` Marc Vertes
2011-11-23 21:43                     ` Wim Van Sebroeck
2011-11-23 21:52                       ` Wolfram Sang
2011-11-24  8:29                         ` Wim Van Sebroeck
2011-11-23 21:46                     ` Wim Van Sebroeck
2011-11-24 10:57                       ` Marc Vertes
2011-11-24 13:42                         ` Wim Van Sebroeck
2011-11-24 14:42                           ` Marc Vertes
2011-11-24 15:48                             ` Wim Van Sebroeck
2011-11-24 16:47                               ` Marc Vertes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111123124037.GN23376@infomag.iguana.be \
    --to=wim@iguana.be \
    --cc=HaraldWelte@viatech.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=marc.vertes@sigfox.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®