From: Felipe Balbi <balbi@ti.com>
To: Michal Nazarewicz <mpn@google.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@suse.de>, Felipe Balbi <balbi@ti.com>,
Thomas Dahlmann <dahlmann.thomas@arcor.de>,
Anton Vorontsov <avorontsov@ru.mvista.com>,
Anatolij Gustschin <agust@denx.de>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Ben Dooks <ben@simtec.co.uk>, Heiko Stubner <heiko@sntech.de>,
Thomas Abraham <thomas.ab@samsung.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/3] usb: udc: Fix gadget driver's speed check in various UDC drivers
Date: Thu, 24 Nov 2011 11:46:52 +0200 [thread overview]
Message-ID: <20111124094651.GR3352@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <12833fb1f3db020248c582c1f947724056a34fe2.1321719300.git.mina86@mina86.com>
[-- Attachment #1: Type: text/plain, Size: 878 bytes --]
On Sat, Nov 19, 2011 at 06:26:25PM +0100, Michal Nazarewicz wrote:
> From: Michal Nazarewicz <mina86@mina86.com>
>
> Several UDC drivers had a gadget driver's speed sanity check of the
> form of:
>
> driver->speed != USB_SPEED_HIGH
>
> or:
>
> driver->speed != USB_SPEED_HIGH && driver->speed != USB_SPEED_FULL
>
> As more and more gadget drivers support USB SuperSpeed, driver->speed
> may be set to USB_SPEED_SUPER and UDC driver should handle such gadget
> correctly. The above checks however fail to recognise USB_SPEED_SUPER
> as a valid speed.
>
> This commit changes the two checks to:
>
> driver->speed < USB_SPEED_HIGH
>
> or:
>
> driver->speed < USB_SPEED_FULL
>
> respectively.
>
> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
> Reported-by: Alan Stern <stern@rowland.harvard.edu>
applied, thanks
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-11-24 9:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.44L0.1111161624570.3443-100000@iolanthe.rowland.org>
2011-11-19 17:26 ` Michal Nazarewicz
2011-11-19 17:27 ` [PATCH 2/3] usb: gadget: replace usb_gadget::is_dualspeed with max_speed Michal Nazarewicz
2011-11-24 11:36 ` Felipe Balbi
2011-11-19 17:27 ` [PATCH 3/3] usb: gadget: rename usb_gadget_driver::speed to max_speed Michal Nazarewicz
2011-11-24 11:36 ` Felipe Balbi
2011-11-19 20:50 ` [PATCH 1/3] usb: udc: Fix gadget driver's speed check in various UDC drivers Heiko Stübner
2011-11-19 21:02 ` Alan Stern
2011-11-24 9:46 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111124094651.GR3352@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=agust@denx.de \
--cc=avorontsov@ru.mvista.com \
--cc=ben@simtec.co.uk \
--cc=dahlmann.thomas@arcor.de \
--cc=gregkh@suse.de \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mpn@google.com \
--cc=stern@rowland.harvard.edu \
--cc=thomas.ab@samsung.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®