mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH, trivial] PNP: Use constant PNP_ID_LEN instead of literal number
@ 2011-11-27 21:26 Witold Szczeponik
  0 siblings, 0 replies; only message in thread
From: Witold Szczeponik @ 2011-11-27 21:26 UTC (permalink / raw)
  To: linux-acpi; +Cc: linux-kernel

The attached patch uses the constant PNP_ID_LEN instead of using a 
literal number for the length of a PNP ID in the scope of PNP quirks.

As a consequence, all IDs used in PNP quirks (c.f. "drivers/pnp/quirks.c") 
are now zero-terminated and standard functions that depend on the IDs 
to be zero-terminated now work reliably (c.f. "strlen" in "drivers/pnp/driver.c", 
function "compare_pnp_id"). 


The patch is applied against 3.1. 


Signed-off-by: Witold Szczeponik <Witold.Szczeponik@gmx.net>



Index: linux/include/linux/pnp.h
===================================================================
--- linux.orig/include/linux/pnp.h
+++ linux/include/linux/pnp.h
@@ -295,7 +295,7 @@ static inline void pnp_set_drvdata(struc
 }
 
 struct pnp_fixup {
-	char id[7];
+	char id[PNP_ID_LEN];
 	void (*quirk_function) (struct pnp_dev * dev);	/* fixup function */
 };
 

-- 
NEU: FreePhone - 0ct/min Handyspartarif mit Geld-zurück-Garantie!		
Jetzt informieren: http://www.gmx.net/de/go/freephone

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-11-27 21:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-27 21:26 [PATCH, trivial] PNP: Use constant PNP_ID_LEN instead of literal number Witold Szczeponik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®