* [PATCH] cifs: Use kcalloc instead of kzalloc to allocate array
@ 2011-11-29 21:08 Thomas Meyer
2011-12-05 19:27 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Meyer @ 2011-11-29 21:08 UTC (permalink / raw)
To: linux-cifs, samba-technical, linux-kernel
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.
The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
--- a/fs/cifs/cifssmb.c 2011-11-13 11:07:56.343959560 +0100
+++ b/fs/cifs/cifssmb.c 2011-11-28 19:47:15.006997976 +0100
@@ -2140,7 +2140,7 @@ cifs_async_writev(struct cifs_writedata
goto async_writev_out;
/* 1 iov per page + 1 for header */
- iov = kzalloc((wdata->nr_pages + 1) * sizeof(*iov), GFP_NOFS);
+ iov = kcalloc(wdata->nr_pages + 1, sizeof(*iov), GFP_NOFS);
if (iov == NULL) {
rc = -ENOMEM;
goto async_writev_out;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] cifs: Use kcalloc instead of kzalloc to allocate array
2011-11-29 21:08 [PATCH] cifs: Use kcalloc instead of kzalloc to allocate array Thomas Meyer
@ 2011-12-05 19:27 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2011-12-05 19:27 UTC (permalink / raw)
To: Thomas Meyer; +Cc: linux-cifs, samba-technical, linux-kernel
On Tue, 29 Nov 2011 22:08:00 +0100
Thomas Meyer <thomas@m3y3r.de> wrote:
> The advantage of kcalloc is, that will prevent integer overflows which could
> result from the multiplication of number of elements and size and it is also
> a bit nicer to read.
>
> The semantic patch that makes this change is available
> in https://lkml.org/lkml/2011/11/25/107
>
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>
> diff -u -p a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
> --- a/fs/cifs/cifssmb.c 2011-11-13 11:07:56.343959560 +0100
> +++ b/fs/cifs/cifssmb.c 2011-11-28 19:47:15.006997976 +0100
> @@ -2140,7 +2140,7 @@ cifs_async_writev(struct cifs_writedata
> goto async_writev_out;
>
> /* 1 iov per page + 1 for header */
> - iov = kzalloc((wdata->nr_pages + 1) * sizeof(*iov), GFP_NOFS);
> + iov = kcalloc(wdata->nr_pages + 1, sizeof(*iov), GFP_NOFS);
> if (iov == NULL) {
> rc = -ENOMEM;
> goto async_writev_out;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Looks correct.
Reviewed-by: Jeff Layton <jlayton@samba.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-05 19:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-29 21:08 [PATCH] cifs: Use kcalloc instead of kzalloc to allocate array Thomas Meyer
2011-12-05 19:27 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®