From: Shawn Guo <shawn.guo@freescale.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Shawn Guo <shawn.guo@linaro.org>,
Sascha Hauer <kernel@pengutronix.de>, <linux-mmc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Chris Ball <cjb@laptop.org>
Subject: Re: [MXS MMC v2 2/4] Some cleanups for the MMC driver
Date: Thu, 8 Dec 2011 17:17:02 +0800 [thread overview]
Message-ID: <20111208091701.GC7913@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <d935557e044d2ebc56b4e70487b519fe722e9017.1323328267.git.LW@KARO-electronics.de>
On Thu, Dec 08, 2011 at 09:17:45AM +0100, Lothar Waßmann wrote:
> - Remove bogus parens around numerical arguments in #define's
> - When defining bit masks, use the #def for the shift count
> instead of repeating the numbers
> - Remove 'break' at end of switch statement
>
> Changes wrt v1:
> - break long lines
> - leave indentation as is
>
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Not sure if Chris will ask you to add proper subject prefix though :)
--
Regards,
Shawn
next prev parent reply other threads:[~2011-12-08 9:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 8:17 [MXS MMC v2 0/4] Some cleanups and fixes for the MXS MMC subsystem Lothar Waßmann
2011-12-08 8:17 ` [MXS MMC v2 1/4] Fix grammatical error in comment Lothar Waßmann
2011-12-08 8:17 ` [MXS MMC v2 2/4] Some cleanups for the MMC driver Lothar Waßmann
2011-12-08 8:17 ` [MXS MMC v2 3/4] Check the return codes of clk_enable() and mxs_reset_block() Lothar Waßmann
2011-12-08 8:17 ` [MXS MMC 4/4] Add an appropriate MODULE_ALIAS Lothar Waßmann
2011-12-08 8:54 ` Wolfram Sang
2011-12-08 8:53 ` [MXS MMC v2 3/4] Check the return codes of clk_enable() and mxs_reset_block() Wolfram Sang
2011-12-08 9:17 ` Shawn Guo [this message]
2011-12-08 8:52 ` [MXS MMC v2 1/4] Fix grammatical error in comment Wolfram Sang
2011-12-08 8:52 ` [MXS MMC v2 0/4] Some cleanups and fixes for the MXS MMC subsystem Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208091701.GC7913@S2100-06.ap.freescale.net \
--to=shawn.guo@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=cjb@laptop.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®