* imx cpufreq build failed
@ 2011-12-09 2:09 Richard Zhao
2011-12-09 2:50 ` [PATCH] arm/imx: fix cpufreq build error Shawn Guo
0 siblings, 1 reply; 4+ messages in thread
From: Richard Zhao @ 2011-12-09 2:09 UTC (permalink / raw)
To: linux-kernel; +Cc: kernel, shawn.guo
CC arch/arm/plat-mxc/cpufreq.o
arch/arm/plat-mxc/cpufreq.c:203: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-mxc/cpufreq.c:203: warning: data definition has no type or storage class
arch/arm/plat-mxc/cpufreq.c:203: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
arch/arm/plat-mxc/cpufreq.c:203: warning: function declaration isn't a prototype
arch/arm/plat-mxc/cpufreq.c:204: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-mxc/cpufreq.c:204: warning: data definition has no type or storage class
arch/arm/plat-mxc/cpufreq.c:204: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
arch/arm/plat-mxc/cpufreq.c:204: warning: function declaration isn't a prototype
arch/arm/plat-mxc/cpufreq.c:205: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-mxc/cpufreq.c:205: warning: data definition has no type or storage class
arch/arm/plat-mxc/cpufreq.c:205: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
arch/arm/plat-mxc/cpufreq.c:205: warning: function declaration isn't a prototype
make[1]: *** [arch/arm/plat-mxc/cpufreq.o] Error 1
make: *** [arch/arm/plat-mxc] Error 2
Thanks
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] arm/imx: fix cpufreq build error
2011-12-09 2:09 imx cpufreq build failed Richard Zhao
@ 2011-12-09 2:50 ` Shawn Guo
2011-12-09 9:16 ` Fabio Estevam
2011-12-09 9:26 ` Wolfram Sang
0 siblings, 2 replies; 4+ messages in thread
From: Shawn Guo @ 2011-12-09 2:50 UTC (permalink / raw)
To: Sascha Hauer; +Cc: Richard Zhao, linux-kernel, linux-arm-kernel, Shawn Guo
This patch adds missing linux/module.h to fix the build error seen
on imx cpuidle driver.
CC arch/arm/plat-mxc/cpufreq.o
arch/arm/plat-mxc/cpufreq.c:203: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-mxc/cpufreq.c:203: warning: data definition has no type or storage class
arch/arm/plat-mxc/cpufreq.c:203: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
arch/arm/plat-mxc/cpufreq.c:203: warning: function declaration isn't a prototype
arch/arm/plat-mxc/cpufreq.c:204: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-mxc/cpufreq.c:204: warning: data definition has no type or storage class
arch/arm/plat-mxc/cpufreq.c:204: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
arch/arm/plat-mxc/cpufreq.c:204: warning: function declaration isn't a prototype
arch/arm/plat-mxc/cpufreq.c:205: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-mxc/cpufreq.c:205: warning: data definition has no type or storage class
arch/arm/plat-mxc/cpufreq.c:205: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
arch/arm/plat-mxc/cpufreq.c:205: warning: function declaration isn't a prototype
make[1]: *** [arch/arm/plat-mxc/cpufreq.o] Error 1
make: *** [arch/arm/plat-mxc] Error 2
Reported-by: Richard Zhao <richard.zhao@freescale.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
arch/arm/plat-mxc/cpufreq.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c
index 74aac96..e3073be 100644
--- a/arch/arm/plat-mxc/cpufreq.c
+++ b/arch/arm/plat-mxc/cpufreq.c
@@ -20,6 +20,7 @@
#include <linux/cpufreq.h>
#include <linux/clk.h>
#include <linux/err.h>
+#include <linux/module.h>
#include <linux/slab.h>
#include <mach/hardware.h>
#include <mach/clock.h>
--
1.7.4.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm/imx: fix cpufreq build error
2011-12-09 2:50 ` [PATCH] arm/imx: fix cpufreq build error Shawn Guo
@ 2011-12-09 9:16 ` Fabio Estevam
2011-12-09 9:26 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2011-12-09 9:16 UTC (permalink / raw)
To: Shawn Guo; +Cc: Sascha Hauer, Richard Zhao, linux-kernel, linux-arm-kernel
On Fri, Dec 9, 2011 at 12:50 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> This patch adds missing linux/module.h to fix the build error seen
> on imx cpuidle driver.
It would be nice to add which was the commit that introduced this build error.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm/imx: fix cpufreq build error
2011-12-09 2:50 ` [PATCH] arm/imx: fix cpufreq build error Shawn Guo
2011-12-09 9:16 ` Fabio Estevam
@ 2011-12-09 9:26 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2011-12-09 9:26 UTC (permalink / raw)
To: Shawn Guo; +Cc: Sascha Hauer, Richard Zhao, linux-kernel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1773 bytes --]
On Fri, Dec 09, 2011 at 10:50:55AM +0800, Shawn Guo wrote:
> This patch adds missing linux/module.h to fix the build error seen
> on imx cpuidle driver.
>
> CC arch/arm/plat-mxc/cpufreq.o
> arch/arm/plat-mxc/cpufreq.c:203: error: expected declaration specifiers or '...' before string constant
> arch/arm/plat-mxc/cpufreq.c:203: warning: data definition has no type or storage class
> arch/arm/plat-mxc/cpufreq.c:203: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> arch/arm/plat-mxc/cpufreq.c:203: warning: function declaration isn't a prototype
> arch/arm/plat-mxc/cpufreq.c:204: error: expected declaration specifiers or '...' before string constant
> arch/arm/plat-mxc/cpufreq.c:204: warning: data definition has no type or storage class
> arch/arm/plat-mxc/cpufreq.c:204: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> arch/arm/plat-mxc/cpufreq.c:204: warning: function declaration isn't a prototype
> arch/arm/plat-mxc/cpufreq.c:205: error: expected declaration specifiers or '...' before string constant
> arch/arm/plat-mxc/cpufreq.c:205: warning: data definition has no type or storage class
> arch/arm/plat-mxc/cpufreq.c:205: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> arch/arm/plat-mxc/cpufreq.c:205: warning: function declaration isn't a prototype
> make[1]: *** [arch/arm/plat-mxc/cpufreq.o] Error 1
> make: *** [arch/arm/plat-mxc] Error 2
>
> Reported-by: Richard Zhao <richard.zhao@freescale.com>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-09 9:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-09 2:09 imx cpufreq build failed Richard Zhao
2011-12-09 2:50 ` [PATCH] arm/imx: fix cpufreq build error Shawn Guo
2011-12-09 9:16 ` Fabio Estevam
2011-12-09 9:26 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®