From: Michal Marek <mmarek@suse.cz>
To: Mike Frysinger <vapier@gentoo.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Tony Finch <dot@dotat.at>
Subject: Re: [PATCH] unifdef: drop unused errno.h include
Date: Sat, 10 Dec 2011 14:54:56 +0100 [thread overview]
Message-ID: <20111210135456.GB22866@sepie.suse.cz> (raw)
In-Reply-To: <1323210410-27111-1-git-send-email-vapier@gentoo.org>
On Tue, Dec 06, 2011 at 05:26:50PM -0500, Mike Frysinger wrote:
> This is the only header on my system that ends up requiring kernel
> headers, so if the kernel headers aren't available, we end up being
> unable to install kernel headers :).
>
> Since this file doesn't actually use anything from errno.h, drop
> the include so it at least makes us a bit more robust on glibc.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> scripts/unifdef.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/unifdef.c b/scripts/unifdef.c
> index 7493c0e..c5dfae5 100644
> --- a/scripts/unifdef.c
> +++ b/scripts/unifdef.c
> @@ -48,7 +48,6 @@
>
> #include <ctype.h>
> #include <err.h>
> -#include <errno.h>
> #include <stdarg.h>
> #include <stdbool.h>
> #include <stdio.h>
Adding unifdef upstream maintainer to Cc. I can apply the patch to the
kernel copy if there is no objection from Tony.
Michal
next prev parent reply other threads:[~2011-12-10 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 22:26 Mike Frysinger
2011-12-10 13:54 ` Michal Marek [this message]
2011-12-12 11:06 ` Tony Finch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111210135456.GB22866@sepie.suse.cz \
--to=mmarek@suse.cz \
--cc=dot@dotat.at \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®