[PATCH] unifdef: drop unused errno.h include

[PATCH] unifdef: drop unused errno.h include

[Mike Frysinger]

This is the only header on my system that ends up requiring kernel
headers, so if the kernel headers aren't available, we end up being
unable to install kernel headers :).

Since this file doesn't actually use anything from errno.h, drop
the include so it at least makes us a bit more robust on glibc.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 scripts/unifdef.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/scripts/unifdef.c b/scripts/unifdef.c
index 7493c0e..c5dfae5 100644
--- a/scripts/unifdef.c
+++ b/scripts/unifdef.c
@@ -48,7 +48,6 @@
 
 #include <ctype.h>
 #include <err.h>
-#include <errno.h>
 #include <stdarg.h>
 #include <stdbool.h>
 #include <stdio.h>
-- 
1.7.6.1

Re: [PATCH] unifdef: drop unused errno.h include

[Michal Marek]

On Tue, Dec 06, 2011 at 05:26:50PM -0500, Mike Frysinger wrote:
> This is the only header on my system that ends up requiring kernel
> headers, so if the kernel headers aren't available, we end up being
> unable to install kernel headers :).
> 
> Since this file doesn't actually use anything from errno.h, drop
> the include so it at least makes us a bit more robust on glibc.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  scripts/unifdef.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/unifdef.c b/scripts/unifdef.c
> index 7493c0e..c5dfae5 100644
> --- a/scripts/unifdef.c
> +++ b/scripts/unifdef.c
> @@ -48,7 +48,6 @@
>  
>  #include <ctype.h>
>  #include <err.h>
> -#include <errno.h>
>  #include <stdarg.h>
>  #include <stdbool.h>
>  #include <stdio.h>

Adding unifdef upstream maintainer to Cc. I can apply the patch to the
kernel copy if there is no objection from Tony.

Michal

Re: [PATCH] unifdef: drop unused errno.h include

[Tony Finch]

On Tue, Dec 06, 2011 at 05:26:50PM -0500, Mike Frysinger wrote:
>
> This is the only header on my system that ends up requiring kernel
> headers, so if the kernel headers aren't available, we end up being
> unable to install kernel headers :).

I have some sympathy for this problem but I tend to think that it's
unreasonable to expect unifdef to work with an incomplete compiler
installation.

> Since this file doesn't actually use anything from errno.h, drop
> the include so it at least makes us a bit more robust on glibc.

The Linux kernel currently has unifdef-2.5. Version 2.6 has better error
handling so it uses the declaration of errno but not any of the E*
values. I could perhaps rejig it to avoid this if it really is important
to be able to bootsrap a system with incomplete headers.

Tony.
-- 
f.anthony.n.finch  <dot@dotat.at>  http://dotat.at/
Lundy, Fastnet, Irish Sea: West, backing south for a time, 5 or 6, increasing
7 to severe gale 9. Moderate or rough, occasionally very rough or high. Rain
or squally wintry showers. Good, occasionally poor.