From: Ingo Molnar <mingo@elte.hu>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
acme@infradead.org, robert.richter@amd.com, ming.m.lin@intel.com,
andi@firstfloor.org, asharma@fb.com
Subject: Re: [PATCH 2/4] perf_event: add PERF_COUNT_HW_REF_CPU_CYCLES generic PMU event
Date: Sun, 11 Dec 2011 09:01:38 +0100 [thread overview]
Message-ID: <20111211080138.GB20790@elte.hu> (raw)
In-Reply-To: <1323559734-3488-3-git-send-email-eranian@google.com>
* Stephane Eranian <eranian@google.com> wrote:
> This event counts the number of reference core cpu cycles.
> Reference means that the event increments at a constant rate
> which is not subject to core CPU frequency adjustments. The
> event may not count when the processor is in halted (low
> power) state. As such, it may not be equivalent to wall clock
> time. However, when the processor is not halted state, the
> event keeps a constant correlation with wall clock time.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
> ---
> include/linux/perf_event.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> index 564769c..0885561 100644
> --- a/include/linux/perf_event.h
> +++ b/include/linux/perf_event.h
> @@ -54,6 +54,7 @@ enum perf_hw_id {
> PERF_COUNT_HW_BUS_CYCLES = 6,
> PERF_COUNT_HW_STALLED_CYCLES_FRONTEND = 7,
> PERF_COUNT_HW_STALLED_CYCLES_BACKEND = 8,
> + PERF_COUNT_HW_REF_CPU_CYCLES = 9,
Btw., that was what 'bus cycles' tried to do a long time ago:
the constant, non-variable baseline heartbeat of the system.
We could simply rename that, fix the event tables where needed,
and keep the ABI.
Just a small detail: how about naming it 'constant [frequency]
CPU cycles'? That's a concept that might be present on other
platforms as well.
CONST_FREQ_CYCLES or so. The 'CPU' can be dropped as well
because it's not really the CPU's frequency anymore.
Thanks,
Ingo
next prev parent reply other threads:[~2011-12-11 8:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 23:28 [PATCH 0/4] perf_events: add support for Intel reference cycles event Stephane Eranian
2011-12-10 23:28 ` [PATCH 1/4] perf_events: enable raw event support for Intel unhalted_reference_cycles event Stephane Eranian
2011-12-21 10:22 ` [tip:perf/core] perf events: Enable " tip-bot for Stephane Eranian
2011-12-10 23:28 ` [PATCH 2/4] perf_event: add PERF_COUNT_HW_REF_CPU_CYCLES generic PMU event Stephane Eranian
2011-12-11 8:01 ` Ingo Molnar [this message]
2011-12-11 12:55 ` Peter Zijlstra
2011-12-11 15:47 ` Ingo Molnar
2011-12-12 3:45 ` Stephane Eranian
2011-12-12 12:57 ` Peter Zijlstra
2011-12-12 17:32 ` Ingo Molnar
2011-12-13 6:45 ` Stephane Eranian
2011-12-13 10:02 ` Peter Zijlstra
2011-12-14 17:42 ` Stephane Eranian
2011-12-21 10:23 ` [tip:perf/core] perf events: Add " tip-bot for Stephane Eranian
2011-12-10 23:28 ` [PATCH 3/4] perf_events: add Intel X86 mapping for PERF_COUNT_HW_REF_CPU_CYCLES Stephane Eranian
2011-12-21 10:24 ` [tip:perf/core] perf events: Add Intel x86 " tip-bot for Stephane Eranian
2011-12-10 23:28 ` [PATCH 4/4] perf: add support for PERF_HW_COUNT_REF_CPU_CYCLES Stephane Eranian
2011-12-21 10:25 ` [tip:perf/core] perf: Add " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111211080138.GB20790@elte.hu \
--to=mingo@elte.hu \
--cc=acme@infradead.org \
--cc=andi@firstfloor.org \
--cc=asharma@fb.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®