From: Grant Likely <grant.likely@secretlab.ca>
To: Feng Tang <feng.tang@intel.com>
Cc: linus.walleij@linaro.org, tomoya-linux@dsn.lapis-semi.com,
linux-kernel@vger.kernel.org, joel.clark@intel.com,
ying.huang@intel.com, qi.wang@intel.com, kok.howg.ewe@intel.com
Subject: Re: [PATCH 1/2] gpio-ml-ioh: fix a bug in the interrupt handler
Date: Tue, 13 Dec 2011 11:05:45 -0700 [thread overview]
Message-ID: <20111213180545.GC4871@ponder.secretlab.ca> (raw)
In-Reply-To: <1323791630-4125-1-git-send-email-feng.tang@intel.com>
On Tue, Dec 13, 2011 at 11:53:49PM +0800, Feng Tang wrote:
> GPIO's irq action's dev_id is set to the first struct ioh_gpio chip,
> so when loop checking the 8 chips, the "chip" should be changed
> according.
>
> Signed-off-by: Feng Tang <feng.tang@intel.com>
Applied, thanks.
g.
> ---
> drivers/gpio/gpio-ml-ioh.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
> index ea8e738..92b6f51 100644
> --- a/drivers/gpio/gpio-ml-ioh.c
> +++ b/drivers/gpio/gpio-ml-ioh.c
> @@ -339,7 +339,7 @@ static irqreturn_t ioh_gpio_handler(int irq, void *dev_id)
> int i, j;
> int ret = IRQ_NONE;
>
> - for (i = 0; i < 8; i++) {
> + for (i = 0; i < 8; i++, chip++) {
> reg_val = ioread32(&chip->reg->regs[i].istatus);
> for (j = 0; j < num_ports[i]; j++) {
> if (reg_val & BIT(j)) {
> --
> 1.7.1
>
next prev parent reply other threads:[~2011-12-13 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 15:53 Feng Tang
2011-12-13 15:53 ` [PATCH 2/2] gpio-ml-ioh: Add the irq_disable/irq_enable hooks for ml-ioh irq chip Feng Tang
2011-12-13 18:05 ` Grant Likely
2011-12-13 18:05 ` Grant Likely [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-11-30 7:51 [PATCH 1/2] gpio-ml-ioh: fix a bug in the interrupt handler Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213180545.GC4871@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=feng.tang@intel.com \
--cc=joel.clark@intel.com \
--cc=kok.howg.ewe@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=tomoya-linux@dsn.lapis-semi.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®