* [PATCH] mfd: Fix cs5535-mfd driver name
@ 2011-12-05 21:46 Jean Delvare
2011-12-19 11:42 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2011-12-05 21:46 UTC (permalink / raw)
To: LKML; +Cc: Samuel Ortiz
Fix cs5535-mfd driver name to make CONFIG_DEBUG_SECTION_MISMATCH=y
happy:
WARNING: drivers/mfd/cs5535-mfd.o(.data+0x20): Section mismatch in reference from the variable cs5535_mfd_drv to the function .devinit.text:cs5535_mfd_probe()
The variable cs5535_mfd_drv references
the function __devinit cs5535_mfd_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>
---
drivers/mfd/cs5535-mfd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-3.2-rc4.orig/drivers/mfd/cs5535-mfd.c 2011-07-22 04:17:23.000000000 +0200
+++ linux-3.2-rc4/drivers/mfd/cs5535-mfd.c 2011-12-05 18:51:49.000000000 +0100
@@ -179,7 +179,7 @@ static struct pci_device_id cs5535_mfd_p
};
MODULE_DEVICE_TABLE(pci, cs5535_mfd_pci_tbl);
-static struct pci_driver cs5535_mfd_drv = {
+static struct pci_driver cs5535_mfd_driver = {
.name = DRV_NAME,
.id_table = cs5535_mfd_pci_tbl,
.probe = cs5535_mfd_probe,
@@ -188,12 +188,12 @@ static struct pci_driver cs5535_mfd_drv
static int __init cs5535_mfd_init(void)
{
- return pci_register_driver(&cs5535_mfd_drv);
+ return pci_register_driver(&cs5535_mfd_driver);
}
static void __exit cs5535_mfd_exit(void)
{
- pci_unregister_driver(&cs5535_mfd_drv);
+ pci_unregister_driver(&cs5535_mfd_driver);
}
module_init(cs5535_mfd_init);
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mfd: Fix cs5535-mfd driver name
2011-12-05 21:46 [PATCH] mfd: Fix cs5535-mfd driver name Jean Delvare
@ 2011-12-19 11:42 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2011-12-19 11:42 UTC (permalink / raw)
To: Jean Delvare; +Cc: LKML
Hi Jean,
On Mon, Dec 05, 2011 at 10:46:39PM +0100, Jean Delvare wrote:
> Fix cs5535-mfd driver name to make CONFIG_DEBUG_SECTION_MISMATCH=y
> happy:
>
> WARNING: drivers/mfd/cs5535-mfd.o(.data+0x20): Section mismatch in reference from the variable cs5535_mfd_drv to the function .devinit.text:cs5535_mfd_probe()
> The variable cs5535_mfd_drv references
> the function __devinit cs5535_mfd_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *driver, *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console
A similar patch is already queued in my for-next branch, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-19 11:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-05 21:46 [PATCH] mfd: Fix cs5535-mfd driver name Jean Delvare
2011-12-19 11:42 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®