[PATCH] btree: Export btree_get_prev() so modules can use btree_for_each

[PATCH] btree: Export btree_get_prev() so modules can use btree_for_each

[Roland Dreier]

From: Steve Hodgson <steve@purestorage.com>

The btree_for_each API is implemented with macros that internally call
btree_get_prev(), so if btree_get_prev() isn't exported then modules
fail to link if they try to use one of the btree_for_each macros.  Since
the rest of the btree API is exported, we should keep things orthogonal
and make this work too.

Cc: Joern Engel <joern@logfs.org>
Signed-off-by: Roland Dreier <roland@purestorage.com>
---
 lib/btree.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lib/btree.c b/lib/btree.c
index 2a34392..e5ec1e9 100644
--- a/lib/btree.c
+++ b/lib/btree.c
@@ -357,6 +357,7 @@ miss:
 	}
 	return NULL;
 }
+EXPORT_SYMBOL_GPL(btree_get_prev);
 
 static int getpos(struct btree_geo *geo, unsigned long *node,
 		unsigned long *key)
-- 
1.7.5.4

Re: [PATCH] btree: Export btree_get_prev() so modules can use btree_for_each

[Jörn Engel]

On Wed, 28 December 2011 00:53:59 -0800, Roland Dreier wrote:
> 
> From: Steve Hodgson <steve@purestorage.com>
> 
> The btree_for_each API is implemented with macros that internally call
> btree_get_prev(), so if btree_get_prev() isn't exported then modules
> fail to link if they try to use one of the btree_for_each macros.  Since
> the rest of the btree API is exported, we should keep things orthogonal
> and make this work too.
> 
> Cc: Joern Engel <joern@logfs.org>
> Signed-off-by: Roland Dreier <roland@purestorage.com>

Acked-by: Joern Engel <joern@logfs.org>

> ---
>  lib/btree.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/btree.c b/lib/btree.c
> index 2a34392..e5ec1e9 100644
> --- a/lib/btree.c
> +++ b/lib/btree.c
> @@ -357,6 +357,7 @@ miss:
>  	}
>  	return NULL;
>  }
> +EXPORT_SYMBOL_GPL(btree_get_prev);
>  
>  static int getpos(struct btree_geo *geo, unsigned long *node,
>  		unsigned long *key)
> -- 
> 1.7.5.4
> 

Jörn

-- 
"Error protection by error detection and correction."
-- from a university class

Re: [PATCH] btree: Export btree_get_prev() so modules can use btree_for_each

[Roland Dreier]

On Sat, Dec 31, 2011 at 7:22 PM, Steve Hodgson <steve@purestorage.com> wrote:
> Signed-off-by: Steve Hodgson
>
> Or you would prefer the patch is resent with my Sign-off in the commit
> message?

A properly formed S-o-b line has the email address too... but in any case I
don't think it should be necessary in this case.  First of all the patch is a
pretty trivial one-liner... but in any case as I understand things I should be
able to submit patches from our company's internal tree and both preserve
authorship (ie "From: Steve") but also be the first person sending it out.

Looking at "Developer's Certificate of Origin 1.1" in SubmittingPatches, I
guess I am certifying (b), ie

        (b) The contribution is based upon previous work that, to the best
            of my knowledge, is covered under an appropriate open source
            license and I have the right under that license to submit that
            work with modifications, whether created in whole or in part
            by me, under the same open source license (unless I am
            permitted to submit under a different license), as indicated
            in the file; or

(Since I actually did write the changelog for the patch)

 - R.