mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, jbarnes@virtuousgeek.org,
	bhelgaas@google.com, gregkh@suse.de, linux-pci@vger.kernel.org
Subject: Re: [PATCH] msi: fix imbalanced refcount of msi irq sysfs objects
Date: Tue, 3 Jan 2012 13:53:05 -0500	[thread overview]
Message-ID: <20120103185304.GA25184@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20120103.130526.2034128205205666131.davem@davemloft.net>

On Tue, Jan 03, 2012 at 01:05:26PM -0500, David Miller wrote:
> From: Neil Horman <nhorman@tuxdriver.com>
> Date: Tue,  3 Jan 2012 10:29:54 -0500
> 
> > This warning was recently reported to me:
> 
> I've hit this too, see:
> 
> http://marc.info/?l=linux-kernel&m=132458146927890&w=2
> 
> and my analysis at:
> 
> http://marc.info/?l=linux-arch&m=132458391128660&w=2
> 
Yup, your analysis is correct. Regardless of the why behind msi enablement
failing, we need to gate the kobject_del/put in free_msi_irqs on successful
completion of kobject_init_and_add in populate_msi_sysfs.  This patch does that,
using the parent pointer as a flag.

Thanks
Neil


  reply	other threads:[~2012-01-03 18:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-03 15:29 Neil Horman
2012-01-03 18:05 ` David Miller
2012-01-03 18:53   ` Neil Horman [this message]
2012-01-04 17:19     ` Jesse Barnes
2012-01-04 19:51       ` Neil Horman
2012-01-04 19:56         ` David Miller
2012-01-04 20:02           ` Jesse Barnes
2012-01-04 21:18             ` Josh Boyer
2012-01-04 21:25               ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120103185304.GA25184@hmsreliant.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®