From: chavey@google.com (Laurent Chavey)
To: Glauber Costa <glommer@parallels.com>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, cgroups@vger.kernel.org,
Greg Thelen <gthelen@google.com>,
Hiroyouki Kamezawa <kamezawa.hiroyu@jp.fujitsu.com>,
Laurent Chavey <chavey@google.com>
Subject: Re: [PATCH] net: fix sock_clone reference mismatch with tcp memcontrol
Date: Fri, 6 Jan 2012 13:14:23 -0800 (PST) [thread overview]
Message-ID: <20120106211423.967A716F64A@chavey.mtv.corp.google.com> (raw)
> Sockets can also be created through sock_clone. Because it copies
> all data in the sock structure, it also copies the memcg-related pointer,
> and all should be fine. However, since we now use reference counts in
> socket creation, we are left with some sockets that have no reference
> counts. It matters when we destroy them, since it leads to a mismatch.
>
> Signed-off-by: Glauber Costa <glommer@parallels.com>
> CC: David S. Miller <davem@davemloft.net>
> CC: Greg Thelen <gthelen@google.com>
> CC: Hiroyouki Kamezawa <kamezawa.hiroyu@jp.fujitsu.com>
> CC: Laurent Chavey <chavey@google.com>
>
> ---
Tested-by: Laurent Chavey <chavey@google.com>
next reply other threads:[~2012-01-06 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 21:14 Laurent Chavey [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-06 6:16 Glauber Costa
2012-01-07 18:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120106211423.967A716F64A@chavey.mtv.corp.google.com \
--to=chavey@google.com \
--cc=cgroups@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=glommer@parallels.com \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®