From: Christoph Hellwig <hch@infradead.org>
To: Asai Thambi SP <asaithambisp@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Sam Bradshaw (sbradshaw)" <sbradshaw@micron.com>,
Asai Thambi S P <asamymuthupa@micron.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtip32xx: rename the confusing argument 'barrier', of mtip_hw_submit_io()
Date: Mon, 23 Jan 2012 15:09:23 -0500 [thread overview]
Message-ID: <20120123200923.GA9801@infradead.org> (raw)
In-Reply-To: <CAKgD3HCqS8MkXbve3sT=8vZ4=Mvdtz-JDmy8N5t7moXcjSV1sg@mail.gmail.com>
On Wed, Jan 18, 2012 at 05:29:40PM -0800, Asai Thambi SP wrote:
> This device does not support write cache, hence renamed confusing argument
> 'barrier' to 'fua'. Setting of FUA bit is done in all IOs for compatibility.
That's not correct, you set it if REQ_FUA is set, which won't ever be
set given how you configure the queue. I.e. it's dead code that can be
removed.
next parent reply other threads:[~2012-01-23 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKgD3HCqS8MkXbve3sT=8vZ4=Mvdtz-JDmy8N5t7moXcjSV1sg@mail.gmail.com>
2012-01-23 20:09 ` Christoph Hellwig [this message]
2012-01-23 20:21 ` Sam Bradshaw (sbradshaw)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120123200923.GA9801@infradead.org \
--to=hch@infradead.org \
--cc=asaithambisp@gmail.com \
--cc=asamymuthupa@micron.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=sbradshaw@micron.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®