* Re: [PATCH] mtip32xx: rename the confusing argument 'barrier', of mtip_hw_submit_io() [not found] <CAKgD3HCqS8MkXbve3sT=8vZ4=Mvdtz-JDmy8N5t7moXcjSV1sg@mail.gmail.com> @ 2012-01-23 20:09 ` Christoph Hellwig 2012-01-23 20:21 ` Sam Bradshaw (sbradshaw) 0 siblings, 1 reply; 2+ messages in thread From: Christoph Hellwig @ 2012-01-23 20:09 UTC (permalink / raw) To: Asai Thambi SP Cc: Jens Axboe, Christoph Hellwig, Linus Torvalds, Sam Bradshaw (sbradshaw), Asai Thambi S P, linux-kernel On Wed, Jan 18, 2012 at 05:29:40PM -0800, Asai Thambi SP wrote: > This device does not support write cache, hence renamed confusing argument > 'barrier' to 'fua'. Setting of FUA bit is done in all IOs for compatibility. That's not correct, you set it if REQ_FUA is set, which won't ever be set given how you configure the queue. I.e. it's dead code that can be removed. ^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] mtip32xx: rename the confusing argument 'barrier', of mtip_hw_submit_io() 2012-01-23 20:09 ` [PATCH] mtip32xx: rename the confusing argument 'barrier', of mtip_hw_submit_io() Christoph Hellwig @ 2012-01-23 20:21 ` Sam Bradshaw (sbradshaw) 0 siblings, 0 replies; 2+ messages in thread From: Sam Bradshaw (sbradshaw) @ 2012-01-23 20:21 UTC (permalink / raw) To: Christoph Hellwig, Asai Thambi SP Cc: Jens Axboe, Linus Torvalds, Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2], linux-kernel > -----Original Message----- > From: Christoph Hellwig [mailto:hch@infradead.org] > Subject: Re: [PATCH] mtip32xx: rename the confusing argument 'barrier', of > mtip_hw_submit_io() > > On Wed, Jan 18, 2012 at 05:29:40PM -0800, Asai Thambi SP wrote: > > This device does not support write cache, hence renamed confusing argument > > 'barrier' to 'fua'. Setting of FUA bit is done in all IOs for compatibility. > > That's not correct, you set it if REQ_FUA is set, which won't ever be > set given how you configure the queue. I.e. it's dead code that can be > removed. That was done intentionally to minimize the scope of changes for future variants of the P320 that do support write cache. We'll go ahead and remove it, however, since it is presently dead code. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-23 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAKgD3HCqS8MkXbve3sT=8vZ4=Mvdtz-JDmy8N5t7moXcjSV1sg@mail.gmail.com>
2012-01-23 20:09 ` [PATCH] mtip32xx: rename the confusing argument 'barrier', of mtip_hw_submit_io() Christoph Hellwig
2012-01-23 20:21 ` Sam Bradshaw (sbradshaw)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®