mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Sound, SoC, WM9090: Remove unused variable 'wm9090' from wm9090_i2c_remove()
@ 2012-01-27 23:57 Jesper Juhl
  2012-01-29 21:42 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Jesper Juhl @ 2012-01-27 23:57 UTC (permalink / raw)
  To: linux-kernel
  Cc: alsa-devel, Takashi Iwai, Jaroslav Kysela, Liam Girdwood,
	Dimitris Papastamos, Mark Brown, Ian Lartey

The variable 'wm9090' is assigned to but never used, so let's just
remove it.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
 sound/soc/codecs/wm9090.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

	compile teste only

diff --git a/sound/soc/codecs/wm9090.c b/sound/soc/codecs/wm9090.c
index 41ebe0d..db1ba30 100644
--- a/sound/soc/codecs/wm9090.c
+++ b/sound/soc/codecs/wm9090.c
@@ -655,10 +655,7 @@ static int wm9090_i2c_probe(struct i2c_client *i2c,
 
 static int __devexit wm9090_i2c_remove(struct i2c_client *i2c)
 {
-	struct wm9090_priv *wm9090 = i2c_get_clientdata(i2c);
-
 	snd_soc_unregister_codec(&i2c->dev);
-
 	return 0;
 }
 
-- 
1.7.8.4


-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Sound, SoC, WM9090: Remove unused variable 'wm9090' from wm9090_i2c_remove()
  2012-01-27 23:57 [PATCH] Sound, SoC, WM9090: Remove unused variable 'wm9090' from wm9090_i2c_remove() Jesper Juhl
@ 2012-01-29 21:42 ` Mark Brown
  2012-01-29 21:43   ` Jesper Juhl
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2012-01-29 21:42 UTC (permalink / raw)
  To: Jesper Juhl
  Cc: linux-kernel, alsa-devel, Takashi Iwai, Jaroslav Kysela,
	Liam Girdwood, Dimitris Papastamos, Ian Lartey

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

On Sat, Jan 28, 2012 at 12:57:42AM +0100, Jesper Juhl wrote:
> The variable 'wm9090' is assigned to but never used, so let's just
> remove it.

There's already a fix in for this (adding use back).

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Sound, SoC, WM9090: Remove unused variable 'wm9090' from wm9090_i2c_remove()
  2012-01-29 21:42 ` Mark Brown
@ 2012-01-29 21:43   ` Jesper Juhl
  0 siblings, 0 replies; 3+ messages in thread
From: Jesper Juhl @ 2012-01-29 21:43 UTC (permalink / raw)
  To: Mark Brown
  Cc: linux-kernel, alsa-devel, Takashi Iwai, Jaroslav Kysela,
	Liam Girdwood, Dimitris Papastamos, Ian Lartey

On Sun, 29 Jan 2012, Mark Brown wrote:

> On Sat, Jan 28, 2012 at 12:57:42AM +0100, Jesper Juhl wrote:
> > The variable 'wm9090' is assigned to but never used, so let's just
> > remove it.
> 
> There's already a fix in for this (adding use back).
> 
Ok. Thank you for letting me know.

-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-29 21:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-27 23:57 [PATCH] Sound, SoC, WM9090: Remove unused variable 'wm9090' from wm9090_i2c_remove() Jesper Juhl
2012-01-29 21:42 ` Mark Brown
2012-01-29 21:43   ` Jesper Juhl

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®