Re: [PATCH] x86, reboot: reduce to a single DMI table for reboot quirks

Re: [PATCH] x86, reboot: reduce to a single DMI table for reboot quirks

[Ingo Molnar]

I've applied your first two patches, thanks Michael!

Regarding this patch, it does not apply cleanly to the latest 
x86 tree:

 2 out of 5 hunks FAILED -- rejects in file arch/x86/kernel/reboot.c

which you can pick up from:

 git pull git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git master

Also, a style nit, these comments:

> +	/* Write zero to CMOS register number 0x0f, which the BIOS POST
> +	   routine will recognize as telling it to do a proper reboot.  (Well
> +	   that's what this book in front of me says -- it may only apply to
> +	   the Phoenix BIOS though, it's not clear).  At the same time,
> +	   disable NMIs by setting the top bit in the CMOS address register,
> +	   as we're about to do peculiar things to the CPU.  I'm not sure if
> +	   `outb_p' is needed instead of just `outb'.  Use it to be on the
> +	   safe side.  (Yes, CMOS_WRITE does outb_p's. -  Paul G.)
> +	 */

and the other similar comments that you move should be coverted 
to the customary (multi-line) comment style:

  /*
   * Comment .....
   * ...... goes here.
   */

specified in Documentation/CodingStyle.

I realize that you only move code here - but it's worth cleaning 
it up a bit when touching it.

Thanks,

        Ingo

Re: [PATCH] x86, reboot: reduce to a single DMI table for reboot quirks

[Michael D Labriola]

12345678901234567890123456789012345678901234567890123456789012345678901234567890
         1         2         3         4         5         6         7  8

Ingo Molnar <mingo@elte.hu> wrote on 01/30/2012 04:55:37 AM:

> I've applied your first two patches, thanks Michael!

Excellent!

> Regarding this patch, it does not apply cleanly to the latest 
> x86 tree:
> 
>  2 out of 5 hunks FAILED -- rejects in file arch/x86/kernel/reboot.c
> 
> which you can pick up from:
> 
>  git pull git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 
master

Ok, I based all of them off v3.2.  I'll rebase off of tip tonight after
the kids are in bed.  ;-)

> Also, a style nit, these comments:
> 
> > +   /* Write zero to CMOS register number 0x0f, which the BIOS POST
> > +      routine will recognize as telling it to do a proper reboot. 
(Well
> > +      that's what this book in front of me says -- it may only apply 
to
> > +      the Phoenix BIOS though, it's not clear).  At the same time,
> > +      disable NMIs by setting the top bit in the CMOS address 
register,
> > +      as we're about to do peculiar things to the CPU.  I'm not sure 
if
> > +      `outb_p' is needed instead of just `outb'.  Use it to be on the
> > +      safe side.  (Yes, CMOS_WRITE does outb_p's. -  Paul G.)
> > +    */
> 
> and the other similar comments that you move should be coverted 
> to the customary (multi-line) comment style:
> 
>   /*
>    * Comment .....
>    * ...... goes here.
>    */
> 
> specified in Documentation/CodingStyle.
> 
> I realize that you only move code here - but it's worth cleaning 
> it up a bit when touching it.

You are requesting that I clean up only the comments that appear in the
diff, correct?  I'll do that as well.

---
Michael D Labriola
Electric Boat
mlabriol@gdeb.com
401-848-8871 (desk)
401-848-8513 (lab)
401-316-9844 (cell)


 

Re: [PATCH] x86, reboot: reduce to a single DMI table for reboot quirks

[Ingo Molnar]

* Michael D Labriola <mlabriol@gdeb.com> wrote:

> > I realize that you only move code here - but it's worth 
> > cleaning it up a bit when touching it.
> 
> You are requesting that I clean up only the comments that 
> appear in the diff, correct?  I'll do that as well.

Yeah, and whatever other cleanliness detail you notice: when we 
touch some code it is the best opportunity to improve it.

I'd also suggest for ou to do it as two patches: first keep your 
existing patch then do a second one on top of it cleaning up any 
details, and send me both.

Thanks,

	Ingo