mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: "Stephen Boyd" <sboyd@codeaurora.org>
Cc: "Michal Marek" <mmarek@suse.cz>, linux-kernel@vger.kernel.org
Subject: [PATCH] tags: fix regex passed to etags and ctags
Date: Mon, 6 Feb 2012 12:40:58 -0800	[thread overview]
Message-ID: <20120206124058.1cf1a23e@s6510.linuxnetplumber.net> (raw)
In-Reply-To: <c1f3d71b6001dfc42ded4ee651e9a82c.squirrel@www.codeaurora.org>

Several of the regular expressions passed to etags and ctags where incorrect
and missing the backslash before the closing paren, causing warning:
  etags: Unmatched ( or \( while compiling pattern

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

---
v2 - cover all regex (not just etags)


--- a/scripts/tags.sh	2012-02-06 12:38:53.243121989 -0800
+++ b/scripts/tags.sh	2012-02-06 12:39:00.507138571 -0800
@@ -130,30 +130,30 @@ exuberant()
 	-I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
 	--extra=+f --c-kinds=+px                                \
 	--regex-asm='/^(ENTRY|_GLOBAL)\(([^)]*)\).*/\2/'        \
-	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/' \
-	--regex-c++='/^TRACE_EVENT\(([^,)]*).*/trace_\1/'		\
-	--regex-c++='/^DEFINE_EVENT\([^,)]*, *([^,)]*).*/trace_\1/'	\
-	--regex-c++='/PAGEFLAG\(([^,)]*).*/Page\1/'			\
-	--regex-c++='/PAGEFLAG\(([^,)]*).*/SetPage\1/'			\
-	--regex-c++='/PAGEFLAG\(([^,)]*).*/ClearPage\1/'		\
-	--regex-c++='/TESTSETFLAG\(([^,)]*).*/TestSetPage\1/'		\
-	--regex-c++='/TESTPAGEFLAG\(([^,)]*).*/Page\1/'			\
-	--regex-c++='/SETPAGEFLAG\(([^,)]*).*/SetPage\1/'		\
-	--regex-c++='/__SETPAGEFLAG\(([^,)]*).*/__SetPage\1/'		\
-	--regex-c++='/TESTCLEARFLAG\(([^,)]*).*/TestClearPage\1/'	\
-	--regex-c++='/__TESTCLEARFLAG\(([^,)]*).*/TestClearPage\1/'	\
-	--regex-c++='/CLEARPAGEFLAG\(([^,)]*).*/ClearPage\1/'		\
-	--regex-c++='/__CLEARPAGEFLAG\(([^,)]*).*/__ClearPage\1/'	\
-	--regex-c++='/__PAGEFLAG\(([^,)]*).*/__SetPage\1/'		\
-	--regex-c++='/__PAGEFLAG\(([^,)]*).*/__ClearPage\1/'		\
-	--regex-c++='/PAGEFLAG_FALSE\(([^,)]*).*/Page\1/'		\
-	--regex-c++='/TESTSCFLAG\(([^,)]*).*/TestSetPage\1/'		\
-	--regex-c++='/TESTSCFLAG\(([^,)]*).*/TestClearPage\1/'		\
-	--regex-c++='/SETPAGEFLAG_NOOP\(([^,)]*).*/SetPage\1/'		\
-	--regex-c++='/CLEARPAGEFLAG_NOOP\(([^,)]*).*/ClearPage\1/'	\
-	--regex-c++='/__CLEARPAGEFLAG_NOOP\(([^,)]*).*/__ClearPage\1/'	\
-	--regex-c++='/TESTCLEARFLAG_FALSE\(([^,)]*).*/TestClearPage\1/' \
-	--regex-c++='/__TESTCLEARFLAG_FALSE\(([^,)]*).*/__TestClearPage\1/'
+	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*\).*/sys_\1/' \
+	--regex-c++='/^TRACE_EVENT\(([^,)]*\).*/trace_\1/'		\
+	--regex-c++='/^DEFINE_EVENT\([^,)]*, *([^,)]*\).*/trace_\1/'	\
+	--regex-c++='/PAGEFLAG\(([^,)]*\).*/Page\1/'			\
+	--regex-c++='/PAGEFLAG\(([^,)]*\).*/SetPage\1/'			\
+	--regex-c++='/PAGEFLAG\(([^,)]*\).*/ClearPage\1/'		\
+	--regex-c++='/TESTSETFLAG\(([^,)]*\).*/TestSetPage\1/'		\
+	--regex-c++='/TESTPAGEFLAG\(([^,)]*\).*/Page\1/'		\
+	--regex-c++='/SETPAGEFLAG\(([^,)]*\).*/SetPage\1/'		\
+	--regex-c++='/__SETPAGEFLAG\(([^,)]*\).*/__SetPage\1/'		\
+	--regex-c++='/TESTCLEARFLAG\(([^,)]*\).*/TestClearPage\1/'	\
+	--regex-c++='/__TESTCLEARFLAG\(([^,)]*\).*/TestClearPage\1/'	\
+	--regex-c++='/CLEARPAGEFLAG\(([^,)]*\).*/ClearPage\1/'		\
+	--regex-c++='/__CLEARPAGEFLAG\(([^,)]*\).*/__ClearPage\1/'	\
+	--regex-c++='/__PAGEFLAG\(([^,)]*\).*/__SetPage\1/'		\
+	--regex-c++='/__PAGEFLAG\(([^,)]*\).*/__ClearPage\1/'		\
+	--regex-c++='/PAGEFLAG_FALSE\(([^,)]*\).*/Page\1/'		\
+	--regex-c++='/TESTSCFLAG\(([^,)]*\).*/TestSetPage\1/'		\
+	--regex-c++='/TESTSCFLAG\(([^,)]*\).*/TestClearPage\1/'		\
+	--regex-c++='/SETPAGEFLAG_NOOP\(([^,)]*\).*/SetPage\1/'		\
+	--regex-c++='/CLEARPAGEFLAG_NOOP\(([^,)]*\).*/ClearPage\1/'	\
+	--regex-c++='/__CLEARPAGEFLAG_NOOP\(([^,)]*\).*/__ClearPage\1/'	\
+	--regex-c++='/TESTCLEARFLAG_FALSE\(([^,)]*\).*/TestClearPage\1/' \
+	--regex-c++='/__TESTCLEARFLAG_FALSE\(([^,)]*\).*/__TestClearPage\1/'
 
 	all_kconfigs | xargs $1 -a                              \
 	--langdef=kconfig --language-force=kconfig              \
@@ -178,27 +178,27 @@ emacs()
 	--regex='/^SYSCALL_DEFINE[0-9]?(\([^,)]*\).*/sys_\1/'   \
 	--regex='/^TRACE_EVENT(\([^,)]*\).*/trace_\1/'		\
 	--regex='/^DEFINE_EVENT([^,)]*, *\([^,)]*\).*/trace_\1/' \
-	--regex='/PAGEFLAG\(([^,)]*).*/Page\1/'			\
-	--regex='/PAGEFLAG\(([^,)]*).*/SetPage\1/'		\
-	--regex='/PAGEFLAG\(([^,)]*).*/ClearPage\1/'		\
-	--regex='/TESTSETFLAG\(([^,)]*).*/TestSetPage\1/'	\
-	--regex='/TESTPAGEFLAG\(([^,)]*).*/Page\1/'		\
-	--regex='/SETPAGEFLAG\(([^,)]*).*/SetPage\1/'		\
-	--regex='/__SETPAGEFLAG\(([^,)]*).*/__SetPage\1/'	\
-	--regex='/TESTCLEARFLAG\(([^,)]*).*/TestClearPage\1/'	\
-	--regex='/__TESTCLEARFLAG\(([^,)]*).*/TestClearPage\1/'	\
-	--regex='/CLEARPAGEFLAG\(([^,)]*).*/ClearPage\1/'	\
-	--regex='/__CLEARPAGEFLAG\(([^,)]*).*/__ClearPage\1/'	\
-	--regex='/__PAGEFLAG\(([^,)]*).*/__SetPage\1/'		\
-	--regex='/__PAGEFLAG\(([^,)]*).*/__ClearPage\1/'	\
-	--regex='/PAGEFLAG_FALSE\(([^,)]*).*/Page\1/'		\
-	--regex='/TESTSCFLAG\(([^,)]*).*/TestSetPage\1/'	\
-	--regex='/TESTSCFLAG\(([^,)]*).*/TestClearPage\1/'	\
-	--regex='/SETPAGEFLAG_NOOP\(([^,)]*).*/SetPage\1/'	\
-	--regex='/CLEARPAGEFLAG_NOOP\(([^,)]*).*/ClearPage\1/'	\
-	--regex='/__CLEARPAGEFLAG_NOOP\(([^,)]*).*/__ClearPage\1/' \
-	--regex='/TESTCLEARFLAG_FALSE\(([^,)]*).*/TestClearPage\1/' \
-	--regex='/__TESTCLEARFLAG_FALSE\(([^,)]*).*/__TestClearPage\1/'
+	--regex='/PAGEFLAG\(([^,)]*\).*/Page\1/'			\
+	--regex='/PAGEFLAG\(([^,)]*\).*/SetPage\1/'		\
+	--regex='/PAGEFLAG\(([^,)]*\).*/ClearPage\1/'		\
+	--regex='/TESTSETFLAG\(([^,)]*\).*/TestSetPage\1/'	\
+	--regex='/TESTPAGEFLAG\(([^,)]*\).*/Page\1/'		\
+	--regex='/SETPAGEFLAG\(([^,)]*\).*/SetPage\1/'		\
+	--regex='/__SETPAGEFLAG\(([^,)]*\).*/__SetPage\1/'	\
+	--regex='/TESTCLEARFLAG\(([^,)]*\).*/TestClearPage\1/'	\
+	--regex='/__TESTCLEARFLAG\(([^,)]*\).*/TestClearPage\1/'	\
+	--regex='/CLEARPAGEFLAG\(([^,)]*\).*/ClearPage\1/'	\
+	--regex='/__CLEARPAGEFLAG\(([^,)]*\).*/__ClearPage\1/'	\
+	--regex='/__PAGEFLAG\(([^,)]*\).*/__SetPage\1/'		\
+	--regex='/__PAGEFLAG\(([^,)]*\).*/__ClearPage\1/'	\
+	--regex='/PAGEFLAG_FALSE\(([^,)]*\).*/Page\1/'		\
+	--regex='/TESTSCFLAG\(([^,)]*\).*/TestSetPage\1/'	\
+	--regex='/TESTSCFLAG\(([^,)]*\).*/TestClearPage\1/'	\
+	--regex='/SETPAGEFLAG_NOOP\(([^,)]*\).*/SetPage\1/'	\
+	--regex='/CLEARPAGEFLAG_NOOP\(([^,)]*\).*/ClearPage\1/'	\
+	--regex='/__CLEARPAGEFLAG_NOOP\(([^,)]*\).*/__ClearPage\1/' \
+	--regex='/TESTCLEARFLAG_FALSE\(([^,)]*\).*/TestClearPage\1/' \
+	--regex='/__TESTCLEARFLAG_FALSE\(([^,)]*\).*/__TestClearPage\1/'
 
 	all_kconfigs | xargs $1 -a                              \
 	--regex='/^[ \t]*\(\(menu\)*config\)[ \t]+\([a-zA-Z0-9_]+\)/\3/'

  reply	other threads:[~2012-02-06 20:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-03 19:27 [PATCH] tags: fix regex passed to etags Stephen Hemminger
2012-02-03 19:42 ` Stephen Boyd
2012-02-03 20:18   ` Stephen Hemminger
2012-02-06 20:32     ` Stephen Boyd
2012-02-06 20:40       ` Stephen Hemminger [this message]
2012-02-06 23:05         ` [PATCH] tags: fix regex passed to etags and ctags Stephen Boyd
2012-02-06 23:15           ` [PATCH] tags: fix use of parenthesis in regex Stephen Hemminger
2012-02-07 19:18             ` Stephen Boyd
2012-02-25  0:34             ` Michal Marek
2012-02-25  0:56               ` Stephen Hemminger
2012-02-25  9:37                 ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120206124058.1cf1a23e@s6510.linuxnetplumber.net \
    --to=shemminger@vyatta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome