* [PATCH] Staging: asus_oled: fix checkpatch.pl issue in asus_oled.c
@ 2012-02-29 3:34 Oliver N. Baumann
2012-02-29 3:46 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Oliver N. Baumann @ 2012-02-29 3:34 UTC (permalink / raw)
To: sjakub, gregkh, pq, baumanno, kernel; +Cc: devel, linux-kernel
From: "Oliver N. Baumann" <baumanno@cip.ifi.lmu.de>
This is a patch to asus_oled.c that fixes a parenthesis issue detected by checkpatch.pl tool
Signed-off-by: Oliver N. Baumann <baumanno@cip.ifi.lmu.de>
---
drivers/staging/asus_oled/asus_oled.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 1df9586..b77f225 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -44,9 +44,9 @@
#define ASUS_OLED_ERROR "Asus OLED Display Error: "
-#define ASUS_OLED_STATIC 's'
-#define ASUS_OLED_ROLL 'r'
-#define ASUS_OLED_FLASH 'f'
+#define ASUS_OLED_STATIC ('s')
+#define ASUS_OLED_ROLL ('r')
+#define ASUS_OLED_FLASH ('f')
#define ASUS_OLED_MAX_WIDTH 1792
#define ASUS_OLED_DISP_HEIGHT 32
--
1.7.5.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Staging: asus_oled: fix checkpatch.pl issue in asus_oled.c
2012-02-29 3:34 [PATCH] Staging: asus_oled: fix checkpatch.pl issue in asus_oled.c Oliver N. Baumann
@ 2012-02-29 3:46 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2012-02-29 3:46 UTC (permalink / raw)
To: Oliver N. Baumann; +Cc: sjakub, pq, baumanno, kernel, devel, linux-kernel
On Wed, Feb 29, 2012 at 04:34:51AM +0100, Oliver N. Baumann wrote:
> From: "Oliver N. Baumann" <baumanno@cip.ifi.lmu.de>
>
> This is a patch to asus_oled.c that fixes a parenthesis issue detected by checkpatch.pl tool
> Signed-off-by: Oliver N. Baumann <baumanno@cip.ifi.lmu.de>
You need a blank line between the changelog text and the signed-off-by
line.
Also, please wrap your changelog entry at 72 columns.
But most of all:
> ---
> drivers/staging/asus_oled/asus_oled.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
> index 1df9586..b77f225 100644
> --- a/drivers/staging/asus_oled/asus_oled.c
> +++ b/drivers/staging/asus_oled/asus_oled.c
> @@ -44,9 +44,9 @@
>
> #define ASUS_OLED_ERROR "Asus OLED Display Error: "
>
> -#define ASUS_OLED_STATIC 's'
> -#define ASUS_OLED_ROLL 'r'
> -#define ASUS_OLED_FLASH 'f'
> +#define ASUS_OLED_STATIC ('s')
> +#define ASUS_OLED_ROLL ('r')
> +#define ASUS_OLED_FLASH ('f')
That's not a valid change, checkpatch is being stupid here, please use
your judgement. This patch changes nothing, go bug the checkpatch
people to fix their tool.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-02-29 3:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-29 3:34 [PATCH] Staging: asus_oled: fix checkpatch.pl issue in asus_oled.c Oliver N. Baumann
2012-02-29 3:46 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®