From: David Miller <davem@davemloft.net>
To: santoshprasadnayak@gmail.com
Cc: bhutchings@solarflare.com, jitendra.kalsaria@qlogic.com,
ron.mercer@qlogic.com, linux-driver@qlogic.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] qla3xxx: ethernet: Fix bogus interrupt state flag.
Date: Fri, 02 Mar 2012 16:13:32 -0500 (EST) [thread overview]
Message-ID: <20120302.161332.2236794166581618113.davem@davemloft.net> (raw)
In-Reply-To: <CAOD=uF5ebyA-yd8T8nXd9vYRw1yvFKVQd9TmcBwMnxFs6enKvA@mail.gmail.com>
From: santosh prasad nayak <santoshprasadnayak@gmail.com>
Date: Fri, 2 Mar 2012 21:24:29 +0530
> In "ql_adapter_initialize", first unlock is done by
> "spin_unlock_irqrestore(&qdev->hw_lock, hw_flags)"
> with "hw_flags = 0" ("hw_flags" is local variable and initialized to
> zero.), which is as good as
> spin_unlock_irq.
You must never pass to irqrestore anything other than a hw_flags
value given by irqsave or similar.
You may not assume anything about what values hw_flags takes on nor
what those values might mean, they are architecture specific so
you may not just set it to zero and assume that does anything in
particular.
next prev parent reply other threads:[~2012-03-02 21:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 15:09 santosh nayak
2012-03-02 15:29 ` Ben Hutchings
2012-03-02 15:54 ` santosh prasad nayak
2012-03-02 21:13 ` David Miller [this message]
2012-03-03 9:31 ` santosh prasad nayak
2012-03-02 18:51 ` Jitendra Kalsaria
2012-03-05 21:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302.161332.2236794166581618113.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=jitendra.kalsaria@qlogic.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
--cc=santoshprasadnayak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®