From: David Miller <davem@davemloft.net>
To: santoshprasadnayak@gmail.com
Cc: jitendra.kalsaria@qlogic.com, ron.mercer@qlogic.com,
linux-driver@qlogic.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] qla3xxx: ethernet: Fix bogus interrupt state flag.
Date: Mon, 05 Mar 2012 16:51:05 -0500 (EST) [thread overview]
Message-ID: <20120305.165105.1278606832898736557.davem@davemloft.net> (raw)
In-Reply-To: <1330700945-18195-1-git-send-email-santoshprasadnayak@gmail.com>
From: santosh nayak <santoshprasadnayak@gmail.com>
Date: Fri, 2 Mar 2012 20:39:05 +0530
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> In 'ql_adapter_initialize'
> the first call for 'spin_unlock_irqrestore()' is with hw_flags = 0,
> which is as good as 'spin_unlock_irq()' (unconditional interrupt
> enabling). If this is intended, then for better performance
> 'spin_unlock_irqrestore()' can be replaced with 'spin_unlock_irq()'
> and 'spin_lock_irqsave()' can be replaced by 'spin_lock_irq()
>
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
This change is definitely correct, applied, thanks.
prev parent reply other threads:[~2012-03-05 21:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 15:09 santosh nayak
2012-03-02 15:29 ` Ben Hutchings
2012-03-02 15:54 ` santosh prasad nayak
2012-03-02 21:13 ` David Miller
2012-03-03 9:31 ` santosh prasad nayak
2012-03-02 18:51 ` Jitendra Kalsaria
2012-03-05 21:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305.165105.1278606832898736557.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jitendra.kalsaria@qlogic.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
--cc=santoshprasadnayak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®