From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Manoj Iyer <manoj.iyer@canonical.com>
Cc: linux-kernel@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
Matthew Garrett <mjg@redhat.com>
Subject: Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS
Date: Sat, 10 Mar 2012 01:28:44 -0300 [thread overview]
Message-ID: <20120310042844.GA14972@khazad-dum.debian.net> (raw)
In-Reply-To: <1331335944-4662-2-git-send-email-manoj.iyer@canonical.com>
On Fri, 09 Mar 2012, Manoj Iyer wrote:
> The newer V series bios reports product version as 'Lenovo'
> instead of 'ThinkPad'. Recoginze this new string so that
> the module can load.
>
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index ea0c607..d68c000 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -8658,7 +8658,7 @@ static int __must_check __init get_thinkpad_model_data(
> }
>
> s = dmi_get_system_info(DMI_PRODUCT_VERSION);
> - if (s && !strnicmp(s, "ThinkPad", 8)) {
> + if (s && !(strnicmp(s, "ThinkPad", 8) && strnicmp(s, "Lenovo", 6))) {
> tp->model_str = kstrdup(s, GFP_KERNEL);
> if (!tp->model_str)
> return -ENOMEM;
So far so good, but what driver functionality works well in these new
lenovo boxes?
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2012-03-10 4:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 23:32 Manoj Iyer
2012-03-09 23:32 ` Manoj Iyer
2012-03-10 4:28 ` Henrique de Moraes Holschuh [this message]
2012-03-10 13:58 ` [ibm-acpi-devel] " Yves-Alexis Perez
2012-03-10 16:06 ` Henrique de Moraes Holschuh
2012-03-12 21:34 ` Manoj Iyer
2012-03-12 23:02 ` Henrique de Moraes Holschuh
2012-03-12 23:57 ` Manoj Iyer
2012-03-13 15:53 ` Manoj Iyer
2012-03-13 20:07 ` Henrique de Moraes Holschuh
2012-03-13 20:19 ` Manoj Iyer
2012-03-20 16:03 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120310042844.GA14972@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=manoj.iyer@canonical.com \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome