Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

[Henrique de Moraes Holschuh <hmh@hmh.eng.br>]

On Sat, 10 Mar 2012, Yves-Alexis Perez wrote:
> On sam., 2012-03-10 at 01:28 -0300, Henrique de Moraes Holschuh wrote:
> > So far so good, but what driver functionality works well in these new
> > lenovo boxes? 
> 
> V-series are Ideapad, so I'm not really sure this need to be added to
> thinkpad-acpi.

Yeah, it is not a thinkpad, not even in name.

However, it just might have enough of the thinkpad ACPI API to work,
thus my question.  What good does thinkpad-acpi do in a Lenovo Ideapad
V-series?   If it does something useful, we can support it (but it
likely needs more than just this patch to be safe).

If it doesn't do anything useful, consider this as an absolute NACK
(i.e. I will outright revert it if it lands).  Loading thinkpad-acpi on
a notebook that doesn't benefit from it is harmful in the long term, as
thinkpad-acpi can suddenly start calling weird stuff in ACPI on that box
and do something bad.   There is a real reason why we restrict IBM-era
stuff to IBM thinkpads, etc.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh